Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core-editoast: stdcm: add work schedules #7343

Merged
merged 3 commits into from
May 21, 2024
Merged

core-editoast: stdcm: add work schedules #7343

merged 3 commits into from
May 21, 2024

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Apr 30, 2024

Fix #7335

@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 56.75676% with 48 lines in your changes are missing coverage. Please review.

Project coverage is 29.35%. Comparing base (39c3cf8) to head (8f9325d).

Files Patch % Lines
editoast/src/views/v2/timetable/stdcm.rs 0.00% 40 Missing ⚠️
...in/fr/sncf/osrd/api/api_v2/stdcm/STDCMRequestV2.kt 57.14% 3 Missing ⚠️
tests/tests/utils/timetable.py 81.81% 2 Missing ⚠️
...n/fr/sncf/osrd/api/api_v2/stdcm/STDCMEndpointV2.kt 0.00% 1 Missing ⚠️
.../preprocessing/implementation/BlockAvailability.kt 95.23% 0 Missing and 1 partial ⚠️
editoast/src/core/v2/stdcm.rs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7343      +/-   ##
============================================
+ Coverage     29.34%   29.35%   +0.01%     
- Complexity     2011     2012       +1     
============================================
  Files          1177     1177              
  Lines        145851   145957     +106     
  Branches       2865     2869       +4     
============================================
+ Hits          42800    42851      +51     
- Misses       101367   101421      +54     
- Partials       1684     1685       +1     
Flag Coverage Δ
core 75.16% <86.84%> (+0.04%) ⬆️
editoast 72.31% <0.00%> (-0.14%) ⬇️
front 9.78% <ø> (ø)
gateway 2.41% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 84.29% <93.75%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eckter eckter force-pushed the ech/work-schedule branch 5 times, most recently from 33ad49b to 10502c2 Compare May 7, 2024 14:00
@eckter eckter force-pushed the ech/work-schedule branch from 10502c2 to a7a4aff Compare May 14, 2024 11:28
@eckter eckter force-pushed the ech/work-schedule branch from a7a4aff to 180fdd0 Compare May 15, 2024 07:54
@eckter eckter changed the title core: stdcm: add work schedules core-editoast: stdcm: add work schedules May 15, 2024
@eckter eckter force-pushed the ech/work-schedule branch from 180fdd0 to 5efd62f Compare May 16, 2024 08:07
@eckter eckter marked this pull request as ready for review May 16, 2024 08:14
@eckter eckter requested review from a team as code owners May 16, 2024 08:14
@eckter eckter requested a review from Khoyo May 16, 2024 08:14
@eckter eckter force-pushed the ech/work-schedule branch 3 times, most recently from e43f2a7 to df26649 Compare May 16, 2024 10:50
Copy link
Contributor

@younesschrifi younesschrifi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I just have one comment 🙂

@eckter eckter force-pushed the ech/work-schedule branch from 6f1cbf7 to 1463eea Compare May 16, 2024 16:04
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not sure how to test it though (do we have an extract of work_schedules we can insert in the DB?).

A few naming nitpicks and a question (nothing blocking though 😄):

@eckter
Copy link
Contributor Author

eckter commented May 17, 2024

not sure how to test it though (do we have an extract of work_schedules we can insert in the DB?).

I've tested using the post /work_schedules/ endpoint. In fact I should probably turn that into a simple integration test.

@eckter eckter requested a review from a team as a code owner May 17, 2024 09:17
@eckter eckter requested a review from bloussou May 17, 2024 09:17
@eckter eckter force-pushed the ech/work-schedule branch from 42593be to 507b7b4 Compare May 17, 2024 12:08
@eckter eckter requested a review from Erashin May 17, 2024 12:08
eckter and others added 2 commits May 21, 2024 15:12
Update editoast/src/views/v2/timetable/stdcm.rs

Co-authored-by: Youness CHRIFI ALAOUI <[email protected]>
@eckter eckter force-pushed the ech/work-schedule branch from 496062d to 8f9325d Compare May 21, 2024 13:12
@eckter eckter enabled auto-merge May 21, 2024 13:12
@eckter eckter added this pull request to the merge queue May 21, 2024
Merged via the queue into dev with commit 1122b54 May 21, 2024
17 checks passed
@eckter eckter deleted the ech/work-schedule branch May 21, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core: stdcm: import and use work schedule
6 participants