-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core-editoast: stdcm: add work schedules #7343
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7343 +/- ##
============================================
+ Coverage 29.34% 29.35% +0.01%
- Complexity 2011 2012 +1
============================================
Files 1177 1177
Lines 145851 145957 +106
Branches 2865 2869 +4
============================================
+ Hits 42800 42851 +51
- Misses 101367 101421 +54
- Partials 1684 1685 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
33ad49b
to
10502c2
Compare
core/src/main/kotlin/fr/sncf/osrd/stdcm/preprocessing/implementation/BlockAvailability.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/fr/sncf/osrd/stdcm/preprocessing/implementation/BlockAvailability.kt
Show resolved
Hide resolved
e43f2a7
to
df26649
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I just have one comment 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, not sure how to test it though (do we have an extract of work_schedules we can insert in the DB?).
A few naming nitpicks and a question (nothing blocking though 😄):
I've tested using the |
Update editoast/src/views/v2/timetable/stdcm.rs Co-authored-by: Youness CHRIFI ALAOUI <[email protected]>
Fix #7335