Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: add utoipa annotation for /infra/id/railjson and /infra/railjson #7358

Merged
merged 3 commits into from
May 7, 2024

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented May 2, 2024

Part of #4580

@hamz2a hamz2a requested review from a team as code owners May 2, 2024 13:44
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2024

Codecov Report

Attention: Patch coverage is 98.78788% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 29.12%. Comparing base (e014172) to head (092280c).
Report is 1 commits behind head on dev.

Files Patch % Lines
...s/InfraSelector/InfraSelectorEditionActionsBar.tsx 0.00% 2 Missing ⚠️
front/src/common/api/osrdEditoastApi.ts 99.66% 1 Missing ⚠️
...ts/InfraSelector/InfraSelectorModalBodyEdition.tsx 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7358      +/-   ##
============================================
+ Coverage     29.02%   29.12%   +0.09%     
  Complexity     2016     2016              
============================================
  Files          1157     1157              
  Lines        142333   142539     +206     
  Branches       2809     2809              
============================================
+ Hits          41309    41511     +202     
- Misses        99370    99374       +4     
  Partials       1654     1654              
Flag Coverage Δ
core 76.29% <ø> (ø)
editoast 72.01% <100.00%> (+<0.01%) ⬆️
front 9.83% <98.67%> (+0.17%) ⬆️
gateway 2.43% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamz2a hamz2a force-pushed the hai/editoast-add-utoipa-annotation-for-infra-railjson branch from 758a8c6 to b51c1b3 Compare May 2, 2024 14:04
@hamz2a hamz2a force-pushed the hai/editoast-add-utoipa-annotation-for-infra-railjson branch from b51c1b3 to 18adc14 Compare May 3, 2024 08:04
@hamz2a hamz2a requested a review from leovalais May 3, 2024 08:05
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! :)

@hamz2a hamz2a force-pushed the hai/editoast-add-utoipa-annotation-for-infra-railjson branch from 18adc14 to 41bbc97 Compare May 3, 2024 13:18
@hamz2a hamz2a force-pushed the hai/editoast-add-utoipa-annotation-for-infra-railjson branch from 41bbc97 to 092280c Compare May 7, 2024 09:07
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not tested ✅

@hamz2a hamz2a added this pull request to the merge queue May 7, 2024
Merged via the queue into dev with commit 97f7997 May 7, 2024
17 checks passed
@hamz2a hamz2a deleted the hai/editoast-add-utoipa-annotation-for-infra-railjson branch May 7, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants