Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: display operational points in infra editor #7381

Merged
merged 1 commit into from
May 7, 2024

Conversation

RomainValls
Copy link
Contributor

@RomainValls RomainValls commented May 7, 2024

@RomainValls RomainValls marked this pull request as ready for review May 7, 2024 13:11
@RomainValls RomainValls requested a review from a team as a code owner May 7, 2024 13:11
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested ✅

@RomainValls RomainValls force-pushed the rvs/front-display-op-points-in-infra-editor branch from 0c62aec to 5d47180 Compare May 7, 2024 13:51
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2024

Codecov Report

Attention: Patch coverage is 3.70370% with 78 lines in your changes are missing coverage. Please review.

Project coverage is 11.54%. Comparing base (052ad62) to head (5d47180).

Files Patch % Lines
front/src/common/Map/Layers/OperationalPoints.tsx 0.00% 33 Missing ⚠️
front/src/applications/editor/Map.tsx 0.00% 9 Missing ⚠️
front/src/applications/referenceMap/Map.tsx 0.00% 8 Missing ⚠️
...ront/src/common/Map/Settings/MapSettingsLayers.tsx 0.00% 7 Missing ⚠️
...mulationResult/components/SimulationResultsMap.tsx 0.00% 7 Missing ⚠️
...ainschedule/components/ManageTrainSchedule/Map.tsx 0.00% 7 Missing ⚠️
...src/applications/editor/components/LayersModal.tsx 0.00% 6 Missing ⚠️
front/src/config/layerOrder.ts 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##                dev    #7381       +/-   ##
=============================================
- Coverage     29.12%   11.54%   -17.58%     
=============================================
  Files          1157      595      -562     
  Lines        142557   102059    -40498     
  Branches       2809      948     -1861     
=============================================
- Hits          41519    11785    -29734     
+ Misses        99384    89333    -10051     
+ Partials       1654      941      -713     
Flag Coverage Δ
core ?
editoast ?
front 9.83% <3.70%> (+<0.01%) ⬆️
gateway 2.43% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RomainValls RomainValls added this pull request to the merge queue May 7, 2024
Merged via the queue into dev with commit 9f1c29d May 7, 2024
17 checks passed
@RomainValls RomainValls deleted the rvs/front-display-op-points-in-infra-editor branch May 7, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants