Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editoast flaky test #7411

Merged
merged 1 commit into from
May 14, 2024
Merged

Fix editoast flaky test #7411

merged 1 commit into from
May 14, 2024

Conversation

leovalais
Copy link
Contributor

@leovalais leovalais commented May 14, 2024

I've run the CI checks a few times and it seems to be fixed now.

@leovalais leovalais force-pushed the lva/fix-modelv2-list-test branch from 5ae1d7b to 7228b78 Compare May 14, 2024 09:22
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.45%. Comparing base (803331e) to head (162a2aa).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7411      +/-   ##
============================================
+ Coverage     29.39%   29.45%   +0.05%     
  Complexity     2016     2016              
============================================
  Files          1162     1162              
  Lines        143505   143505              
  Branches       2809     2809              
============================================
+ Hits          42184    42265      +81     
+ Misses        99667    99586      -81     
  Partials       1654     1654              
Flag Coverage Δ
core 76.29% <ø> (ø)
editoast 72.33% <100.00%> (+0.28%) ⬆️
front 9.83% <ø> (ø)
gateway 2.41% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leovalais leovalais force-pushed the lva/fix-modelv2-list-test branch from 7228b78 to c8c1c8f Compare May 14, 2024 09:44
@leovalais leovalais marked this pull request as ready for review May 14, 2024 09:45
@leovalais leovalais requested a review from a team as a code owner May 14, 2024 09:45
@leovalais leovalais enabled auto-merge May 14, 2024 09:46
@leovalais leovalais force-pushed the lva/fix-modelv2-list-test branch from e5c9708 to 162a2aa Compare May 14, 2024 10:45
@leovalais leovalais marked this pull request as draft May 14, 2024 10:54
auto-merge was automatically disabled May 14, 2024 10:54

Pull request was converted to draft

@leovalais leovalais marked this pull request as ready for review May 14, 2024 11:14
@leovalais leovalais requested a review from woshilapin May 14, 2024 11:14
@woshilapin woshilapin added this pull request to the merge queue May 14, 2024
Merged via the queue into dev with commit af41523 May 14, 2024
17 checks passed
@woshilapin woshilapin deleted the lva/fix-modelv2-list-test branch May 14, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants