Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace MinPerKm with MinPer100Km #7435

Merged
merged 3 commits into from
May 16, 2024
Merged

Replace MinPerKm with MinPer100Km #7435

merged 3 commits into from
May 16, 2024

Conversation

younesschrifi
Copy link
Contributor

No description provided.

@younesschrifi younesschrifi requested review from a team as code owners May 16, 2024 14:15
@younesschrifi younesschrifi requested a review from eckter May 16, 2024 14:15
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.49%. Comparing base (ad08ba1) to head (8112ecd).

❗ Current head 8112ecd differs from pull request most recent head fb9ba0b. Consider uploading reports for the commit fb9ba0b to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##                dev    #7435       +/-   ##
=============================================
+ Coverage     29.39%   87.49%   +58.09%     
=============================================
  Files          1172       31     -1141     
  Lines        145257     1535   -143722     
  Branches       2822        0     -2822     
=============================================
- Hits          42694     1343    -41351     
+ Misses       100899      192   -100707     
+ Partials       1664        0     -1664     
Flag Coverage Δ
core ?
editoast ?
front ?
gateway ?
railjson_generator 87.49% <ø> (ø)
tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to adapt core deserialization. (not tested)

@younesschrifi younesschrifi force-pushed the yci/rename-min-per-km branch from 9188fd9 to 8112ecd Compare May 16, 2024 14:38
@younesschrifi younesschrifi force-pushed the yci/rename-min-per-km branch from 8112ecd to fb9ba0b Compare May 16, 2024 14:40
@younesschrifi younesschrifi enabled auto-merge May 16, 2024 14:48
@younesschrifi younesschrifi added this pull request to the merge queue May 16, 2024
Merged via the queue into dev with commit 539b93a May 16, 2024
17 checks passed
@younesschrifi younesschrifi deleted the yci/rename-min-per-km branch May 16, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants