-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenApi annotations for some /infra/{id} endpoints #7442
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7442 +/- ##
============================================
+ Coverage 29.26% 29.33% +0.07%
Complexity 2012 2012
============================================
Files 1194 1196 +2
Lines 146864 147036 +172
Branches 2889 2889
============================================
+ Hits 42978 43133 +155
- Misses 102186 102203 +17
Partials 1700 1700
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
e6de359
to
dc5a5ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More OpenAPI , yeah 🎉
9038df5
to
76fe263
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm but waiting for conflict fix to approve (and editoast test are failing)
f4d5f10
to
00f9209
Compare
Also the front becomes required to provide a name for the new infra for i18n reasons. We keep the " (clone)" suffix for the CLI command though. Removes a test that was testing this behaviour.
00f9209
to
573af8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Tip
Better review each commit separately