Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenApi annotations for some /infra/{id} endpoints #7442

Merged
merged 6 commits into from
May 23, 2024

Conversation

leovalais
Copy link
Contributor

@leovalais leovalais commented May 16, 2024

Tip

Better review each commit separately

@codecov-commenter
Copy link

codecov-commenter commented May 16, 2024

Codecov Report

Attention: Patch coverage is 67.14976% with 68 lines in your changes are missing coverage. Please review.

Project coverage is 29.33%. Comparing base (fd6a65c) to head (7dfdc88).
Report is 8 commits behind head on dev.

Files Patch % Lines
front/src/common/api/osrdEditoastApi.ts 90.24% 8 Missing ⚠️
...pathfinding/components/Pathfinding/Pathfinding.tsx 0.00% 6 Missing ⚠️
...thfinding/components/Pathfinding/PathfindingV2.tsx 0.00% 6 Missing ⚠️
...plications/operationalStudies/views/ScenarioV1.tsx 0.00% 5 Missing ⚠️
...cations/operationalStudies/views/v2/ScenarioV2.tsx 0.00% 5 Missing ⚠️
front/src/applications/editor/Home.tsx 0.00% 4 Missing ⚠️
front/src/applications/referenceMap/Home.tsx 0.00% 4 Missing ⚠️
...s/InfraSelector/InfraSelectorEditionActionsBar.tsx 0.00% 4 Missing ⚠️
...s/infra/components/InfraSelector/InfraSelector.tsx 0.00% 3 Missing ⚠️
front/src/applications/editor/Editor.tsx 0.00% 2 Missing ⚠️
... and 11 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7442      +/-   ##
============================================
+ Coverage     29.26%   29.33%   +0.07%     
  Complexity     2012     2012              
============================================
  Files          1194     1196       +2     
  Lines        146864   147036     +172     
  Branches       2889     2889              
============================================
+ Hits          42978    43133     +155     
- Misses       102186   102203      +17     
  Partials       1700     1700              
Flag Coverage Δ
core 75.07% <ø> (ø)
editoast 72.49% <98.43%> (+0.09%) ⬆️
front 9.76% <53.14%> (+<0.01%) ⬆️
gateway 2.41% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 84.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leovalais leovalais force-pushed the lva/infra-openapi branch from e6de359 to dc5a5ee Compare May 16, 2024 22:39
@leovalais leovalais marked this pull request as ready for review May 16, 2024 23:05
@leovalais leovalais requested review from a team as code owners May 16, 2024 23:05
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More OpenAPI , yeah 🎉

@leovalais leovalais force-pushed the lva/infra-openapi branch 2 times, most recently from 9038df5 to 76fe263 Compare May 17, 2024 14:28
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm but waiting for conflict fix to approve (and editoast test are failing)

@leovalais leovalais force-pushed the lva/infra-openapi branch 2 times, most recently from f4d5f10 to 00f9209 Compare May 21, 2024 09:37
@leovalais leovalais enabled auto-merge May 21, 2024 11:15
@leovalais leovalais requested a review from SharglutDev May 22, 2024 13:12
@leovalais leovalais force-pushed the lva/infra-openapi branch from 00f9209 to 573af8c Compare May 23, 2024 13:35
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@leovalais leovalais added this pull request to the merge queue May 23, 2024
Merged via the queue into dev with commit 6dca1a6 May 23, 2024
17 checks passed
@leovalais leovalais deleted the lva/infra-openapi branch May 23, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants