Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace gradients with curves #7447

Merged
merged 2 commits into from
May 17, 2024
Merged

Conversation

younesschrifi
Copy link
Contributor

No description provided.

@younesschrifi younesschrifi force-pushed the yci/replace-gradient-with-curve branch from 6194d02 to 6fda6f0 Compare May 17, 2024 10:12
@codecov-commenter
Copy link

codecov-commenter commented May 17, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 29.38%. Comparing base (e1280e9) to head (6fda6f0).
Report is 4 commits behind head on dev.

Files Patch % Lines
editoast/src/views/v2/path/properties.rs 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7447      +/-   ##
============================================
- Coverage     29.39%   29.38%   -0.01%     
- Complexity     2011     2012       +1     
============================================
  Files          1172     1173       +1     
  Lines        145251   145275      +24     
  Branches       2822     2828       +6     
============================================
  Hits          42691    42691              
- Misses       100896   100918      +22     
- Partials       1664     1666       +2     
Flag Coverage Δ
core 75.19% <100.00%> (-0.06%) ⬇️
editoast 72.43% <0.00%> (-0.04%) ⬇️
front 9.80% <100.00%> (-0.01%) ⬇️
gateway 2.41% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@younesschrifi younesschrifi marked this pull request as ready for review May 17, 2024 10:12
@younesschrifi younesschrifi requested review from a team as code owners May 17, 2024 10:12
@younesschrifi younesschrifi requested a review from Erashin May 17, 2024 10:12
Copy link
Contributor

@Erashin Erashin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core LGTM.

Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for editoast. I don't even understand why it was named gradient 🤷

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@younesschrifi younesschrifi added this pull request to the merge queue May 17, 2024
Merged via the queue into dev with commit f6e3e93 May 17, 2024
17 checks passed
@younesschrifi younesschrifi deleted the yci/replace-gradient-with-curve branch May 17, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants