Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt stdcm simulation report sheet to new endpoint #7456

Merged
merged 1 commit into from
May 31, 2024

Conversation

Akctarus
Copy link
Contributor

closes #7010

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2024

Codecov Report

Attention: Patch coverage is 1.33843% with 516 lines in your changes are missing coverage. Please review.

Project coverage is 29.14%. Comparing base (5f8b875) to head (8633e51).

Files Patch % Lines
...tions/stdcm/components/SimulationReportSheetV2.tsx 0.00% 352 Missing and 1 partial ⚠️
front/src/applications/stdcm/utils.ts 0.00% 73 Missing and 1 partial ⚠️
...nt/src/applications/stdcm/views/StdcmResultsV2.tsx 0.00% 48 Missing ⚠️
front/src/utils/date.ts 21.87% 25 Missing ⚠️
front/src/applications/stdcm/views/StdcmConfig.tsx 0.00% 15 Missing ⚠️
...ainschedule/components/ManageTrainSchedule/Map.tsx 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7456      +/-   ##
============================================
- Coverage     29.24%   29.14%   -0.11%     
  Complexity     2021     2021              
============================================
  Files          1209     1210       +1     
  Lines        147673   148187     +514     
  Branches       2914     2915       +1     
============================================
+ Hits          43193    43195       +2     
- Misses       102760   103271     +511     
- Partials       1720     1721       +1     
Flag Coverage Δ
core 74.99% <ø> (ø)
editoast 71.94% <ø> (-0.02%) ⬇️
front 10.05% <1.33%> (-0.05%) ⬇️
gateway 2.41% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 71.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Akctarus Akctarus force-pushed the tmn/adapt-stdcm-simulation-report-sheet-to-new-endpoint branch 3 times, most recently from e2101db to 937fdef Compare May 27, 2024 13:05
@Akctarus Akctarus force-pushed the tmn/adapt-stdcm-simulation-report-sheet-to-new-endpoint branch 8 times, most recently from b624b4e to 337d4c0 Compare May 31, 2024 10:16
@Akctarus Akctarus marked this pull request as ready for review May 31, 2024 10:17
@Akctarus Akctarus requested a review from a team as a code owner May 31, 2024 10:17
@Akctarus Akctarus force-pushed the tmn/adapt-stdcm-simulation-report-sheet-to-new-endpoint branch from 337d4c0 to 0675e3f Compare May 31, 2024 10:20
@Akctarus Akctarus force-pushed the tmn/adapt-stdcm-simulation-report-sheet-to-new-endpoint branch from efcacd8 to 44dcd3c Compare May 31, 2024 15:05
@Akctarus Akctarus force-pushed the tmn/adapt-stdcm-simulation-report-sheet-to-new-endpoint branch from 44dcd3c to 8633e51 Compare May 31, 2024 15:08
Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

@Math-R Math-R enabled auto-merge May 31, 2024 15:10
@Math-R Math-R added this pull request to the merge queue May 31, 2024
Merged via the queue into dev with commit 9549537 May 31, 2024
17 checks passed
@Math-R Math-R deleted the tmn/adapt-stdcm-simulation-report-sheet-to-new-endpoint branch May 31, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

STDCM simulation report sheet: adapt to new endpoint
4 participants