Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: stdcm: account for departure time when checking for conflicts #7469

Merged
merged 1 commit into from
May 21, 2024

Conversation

eckter
Copy link
Contributor

@eckter eckter commented May 21, 2024

No description provided.

@eckter eckter requested a review from Erashin May 21, 2024 14:33
@eckter eckter requested a review from a team as a code owner May 21, 2024 14:33
@eckter eckter enabled auto-merge May 21, 2024 14:41
@codecov-commenter
Copy link

codecov-commenter commented May 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 29.33%. Comparing base (39c3cf8) to head (7c3f28c).
Report is 3 commits behind head on dev.

Files Patch % Lines
...n/fr/sncf/osrd/api/api_v2/stdcm/STDCMEndpointV2.kt 0.00% 10 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7469      +/-   ##
============================================
- Coverage     29.34%   29.33%   -0.01%     
  Complexity     2011     2011              
============================================
  Files          1177     1177              
  Lines        145851   145856       +5     
  Branches       2865     2865              
============================================
- Hits          42800    42790      -10     
- Misses       101367   101382      +15     
  Partials       1684     1684              
Flag Coverage Δ
core 75.09% <0.00%> (-0.03%) ⬇️
editoast 72.41% <ø> (-0.04%) ⬇️
front 9.78% <ø> (ø)
gateway 2.41% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eckter eckter added this pull request to the merge queue May 21, 2024
Merged via the queue into dev with commit 1cd4f07 May 21, 2024
17 checks passed
@eckter eckter deleted the ech/fix-stdcm-v2 branch May 21, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants