Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: move sql requests from views::rolling_stock to modelsv2::rolling_stock #7470

Merged

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented May 21, 2024

Part of #6397

@hamz2a hamz2a requested a review from a team as a code owner May 21, 2024 15:24
@codecov-commenter
Copy link

codecov-commenter commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.68%. Comparing base (39c3cf8) to head (803947b).
Report is 19 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##                dev    #7470       +/-   ##
=============================================
- Coverage     29.34%   18.68%   -10.66%     
- Complexity     2011     2013        +2     
=============================================
  Files          1177      914      -263     
  Lines        145851   116919    -28932     
  Branches       2865     2872        +7     
=============================================
- Hits          42800    21852    -20948     
+ Misses       101367    93382     -7985     
- Partials       1684     1685        +1     
Flag Coverage Δ
core 75.14% <ø> (+0.02%) ⬆️
editoast ?
front 9.79% <ø> (+<0.01%) ⬆️
gateway 2.41% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 84.29% <ø> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few things to fix, and the same comment as in your other PR.

@hamz2a hamz2a force-pushed the hai/editoast-move-sql-requests-from-rolling-stock-views-to-modelsv2 branch from d1b3faf to d8e1a81 Compare May 22, 2024 07:58
@hamz2a hamz2a requested a review from leovalais May 22, 2024 14:04
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hamz2a hamz2a force-pushed the hai/editoast-move-sql-requests-from-rolling-stock-views-to-modelsv2 branch from 222721c to 803947b Compare May 22, 2024 14:47
@hamz2a hamz2a force-pushed the hai/editoast-move-sql-requests-from-rolling-stock-views-to-modelsv2 branch from 803947b to 9c61a08 Compare May 22, 2024 15:03
@hamz2a hamz2a added this pull request to the merge queue May 22, 2024
Merged via the queue into dev with commit 73b7a72 May 22, 2024
17 checks passed
@hamz2a hamz2a deleted the hai/editoast-move-sql-requests-from-rolling-stock-views-to-modelsv2 branch May 22, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants