-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editoast: move sql requests from views::rolling_stock
to modelsv2::rolling_stock
#7470
editoast: move sql requests from views::rolling_stock
to modelsv2::rolling_stock
#7470
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7470 +/- ##
=============================================
- Coverage 29.34% 18.68% -10.66%
- Complexity 2011 2013 +2
=============================================
Files 1177 914 -263
Lines 145851 116919 -28932
Branches 2865 2872 +7
=============================================
- Hits 42800 21852 -20948
+ Misses 101367 93382 -7985
- Partials 1684 1685 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A few things to fix, and the same comment as in your other PR.
d1b3faf
to
d8e1a81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
editoast/src/modelsv2/rolling_stock_model/train_schedule_scenario_study_project.rs
Outdated
Show resolved
Hide resolved
222721c
to
803947b
Compare
803947b
to
9c61a08
Compare
Part of #6397