Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ModelV2 List in infra listing endpoint #7541

Merged
merged 2 commits into from
May 29, 2024
Merged

Conversation

leovalais
Copy link
Contributor

No description provided.

@leovalais leovalais requested a review from a team as a code owner May 28, 2024 20:23
@leovalais leovalais self-assigned this May 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 28, 2024

Codecov Report

Attention: Patch coverage is 91.48936% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 29.36%. Comparing base (a2a2125) to head (96c9c81).

Files Patch % Lines
editoast/src/views/infra/mod.rs 92.59% 4 Missing ⚠️
editoast/src/views/timetable/import.rs 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7541      +/-   ##
============================================
- Coverage     29.37%   29.36%   -0.02%     
  Complexity     2014     2014              
============================================
  Files          1200     1200              
  Lines        147403   147380      -23     
  Branches       2892     2892              
============================================
- Hits          43306    43275      -31     
- Misses       102395   102403       +8     
  Partials       1702     1702              
Flag Coverage Δ
core 75.09% <ø> (ø)
editoast 72.50% <86.20%> (-0.05%) ⬇️
front 9.75% <100.00%> (-0.01%) ⬇️
gateway 2.41% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 71.85% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leovalais leovalais force-pushed the lva/modelv2-list-infra branch from 91d9ec0 to 96c9c81 Compare May 28, 2024 20:46
@leovalais leovalais requested a review from a team as a code owner May 28, 2024 20:46
@leovalais leovalais requested a review from shenriotpro May 28, 2024 20:46
@leovalais leovalais changed the title Implement ModelV2 List for infras Use ModelV2 List in infra listing endpoint May 28, 2024
Copy link
Contributor

@shenriotpro shenriotpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for tests/

Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One less API in openapi_legacy.yaml, yeah 🎉

@leovalais leovalais added this pull request to the merge queue May 29, 2024
Merged via the queue into dev with commit 3906d4d May 29, 2024
17 checks passed
@leovalais leovalais deleted the lva/modelv2-list-infra branch May 29, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants