Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: use ModelV2 List in scenario listing endpoint #7545

Merged
merged 2 commits into from
May 29, 2024

Conversation

leovalais
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.65%. Comparing base (a2a2125) to head (db7d0dc).
Report is 4 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##                dev    #7545       +/-   ##
=============================================
- Coverage     29.37%   18.65%   -10.73%     
  Complexity     2014     2014               
=============================================
  Files          1200      928      -272     
  Lines        147403   118081    -29322     
  Branches       2892     2893        +1     
=============================================
- Hits          43306    22028    -21278     
+ Misses       102395    94350     -8045     
- Partials       1702     1703        +1     
Flag Coverage Δ
core 75.07% <ø> (-0.02%) ⬇️
editoast ?
front 9.75% <100.00%> (-0.01%) ⬇️
gateway 2.41% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 71.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leovalais leovalais force-pushed the lva/modelv2-list-scenario branch from 99805fc to fc5179c Compare May 29, 2024 09:48
@leovalais leovalais force-pushed the lva/modelv2-list-scenario branch from fc5179c to db7d0dc Compare May 29, 2024 10:03
@leovalais leovalais marked this pull request as ready for review May 29, 2024 10:13
@leovalais leovalais requested a review from a team as a code owner May 29, 2024 10:13
@leovalais leovalais self-assigned this May 29, 2024
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@leovalais leovalais added this pull request to the merge queue May 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 29, 2024
@leovalais leovalais added this pull request to the merge queue May 29, 2024
Merged via the queue into dev with commit 4a52cb7 May 29, 2024
17 checks passed
@leovalais leovalais deleted the lva/modelv2-list-scenario branch May 29, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants