Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tracing's pretty formatter for editoast logs #7548

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

leovalais
Copy link
Contributor

Configures tracing formatter to pretty to improve log readability. This is especially valuable for multiline log entries. Likewise, the span contexts output is more readable (one line per span instead of joining them using : for the compact formatter).

@leovalais leovalais requested a review from a team as a code owner May 29, 2024 12:40
@codecov-commenter
Copy link

codecov-commenter commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.38%. Comparing base (4bdd9b5) to head (74bd195).
Report is 3 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #7548   +/-   ##
=========================================
  Coverage     29.37%   29.38%           
  Complexity     2014     2014           
=========================================
  Files          1200     1200           
  Lines        147411   147488   +77     
  Branches       2893     2894    +1     
=========================================
+ Hits          43303    43337   +34     
- Misses       102405   102447   +42     
- Partials       1703     1704    +1     
Flag Coverage Δ
core 75.06% <ø> (-0.01%) ⬇️
editoast 72.46% <ø> (-0.08%) ⬇️
front 9.76% <ø> (ø)
gateway 2.41% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 71.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leovalais
Copy link
Contributor Author

Thanks for the approve! Since this change is a bit opinionated, I'll wait before merging maybe until the end of the week to let someone who would be strongly opinionated against that speak out.

@leovalais leovalais added this pull request to the merge queue Jun 11, 2024
Merged via the queue into dev with commit 1e88977 Jun 11, 2024
17 checks passed
@leovalais leovalais deleted the lva/tracing-format-pretty branch June 11, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants