editoast: refactor Infra tests part 1

[hamz2a]

Part of #6980

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.00%. Comparing base (cfeb8eb) to head (edbb371).
Report is 9 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff              @@
##                dev    #7557      +/-   ##
============================================
- Coverage     29.35%   29.00%   -0.36%     
- Complexity     2014     2021       +7     
============================================
  Files          1200     1207       +7     
  Lines        147406   147365      -41     
  Branches       2894     2909      +15     
============================================
- Hits          43276    42747     -529     
- Misses       102426   102903     +477     
- Partials       1704     1715      +11     

Flag	Coverage Δ
core	74.99% <ø> (-0.07%)	⬇️
editoast	71.93% <100.00%> (-0.54%)	⬇️
front	9.70% <ø> (-0.04%)	⬇️
gateway	2.41% <ø> (ø)
railjson_generator	87.49% <ø> (ø)
tests	71.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[leovalais]

Nice PR! Here's a few suggestions:

• Your first commit message is too long. We try to enforce a 70 character limit.

• You can squash your second and third commit to avoid commented code in the history.

• There are many tests that are very similar and duplicated for each object type. A nice improvement would be to write a macro_rule! to factorize all that (just like test_persist!).

• This would be not only valuable to decrease the amount of code, but also to have fewer SQL requests to migrate when we'll try to eliminate diesel outside of editoast_models.

• Speaking of, some requests may be rewritten using ModelV2's API for listing and counting. If you use a macro, the rewrite would occur only in one place ;)

Except for the git part, none of this is blocking, but it might be worth doing that now while you're working on this part of the code. This way we'll have less work down the line to get a proper models split :)

[leovalais]

Good job with the macros! :D

Just a few details and 🚀