Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix: add some useful dev dependencies #7560

Merged
merged 1 commit into from
May 31, 2024

Conversation

woshilapin
Copy link
Contributor

  • 'mold' can be used to greatly improve compilation times (especially link phase).
  • 'ruff' and 'pylsp' are LSP servers useful for configuring IDE that supports it.
    • pylsp brings autocompletion and navigation in the code
    • ruff brings lints

@woshilapin woshilapin requested a review from a team as a code owner May 30, 2024 13:35
@codecov-commenter
Copy link

codecov-commenter commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.26%. Comparing base (2edc6ff) to head (07a9685).
Report is 7 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7560      +/-   ##
============================================
- Coverage     29.35%   29.26%   -0.10%     
  Complexity     2014     2014              
============================================
  Files          1200     1207       +7     
  Lines        147403   147881     +478     
  Branches       2894     2901       +7     
============================================
+ Hits          43277    43281       +4     
- Misses       102422   102889     +467     
- Partials       1704     1711       +7     
Flag Coverage Δ
core 75.06% <ø> (ø)
editoast 72.46% <ø> (-0.02%) ⬇️
front 9.70% <ø> (-0.04%) ⬇️
gateway 2.41% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 71.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@multun
Copy link
Contributor

multun commented May 30, 2024

Rust won't use mold unless you tell it to though

Copy link
Member

@ElysaSrc ElysaSrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- 'mold' can be used to greatly improve compilation times (especially link phase).
- 'ruff' and 'pylsp' are LSP servers useful for configuring IDE that supports it.
@woshilapin woshilapin force-pushed the wsl/chore/nix/add-missing-dependencies branch from 3bbea48 to 07a9685 Compare May 31, 2024 08:31
@woshilapin woshilapin requested a review from multun May 31, 2024 08:32
@multun multun enabled auto-merge May 31, 2024 08:35
@multun multun added this pull request to the merge queue May 31, 2024
Merged via the queue into dev with commit a263797 May 31, 2024
17 checks passed
@multun multun deleted the wsl/chore/nix/add-missing-dependencies branch May 31, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants