Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: remove sentry #7574

Merged
merged 1 commit into from
Jun 17, 2024
Merged

front: remove sentry #7574

merged 1 commit into from
Jun 17, 2024

Conversation

woshilapin
Copy link
Contributor

follow-up on #7241

@woshilapin woshilapin requested a review from a team as a code owner May 31, 2024 14:50
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.49%. Comparing base (e97a8a1) to head (a01a37b).
Report is 13 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##                dev    #7574       +/-   ##
=============================================
+ Coverage     29.00%   87.49%   +58.48%     
=============================================
  Files          1207       31     -1176     
  Lines        147365     1535   -145830     
  Branches       2909        0     -2909     
=============================================
- Hits          42747     1343    -41404     
+ Misses       102903      192   -102711     
+ Partials       1715        0     -1715     
Flag Coverage Δ
core ?
editoast ?
front ?
gateway ?
railjson_generator 87.49% <ø> (ø)
tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emersion
Copy link
Member

emersion commented Jun 4, 2024

Seems like there are a few remaining mentions of Sentry in .env.example and .env.local.defaults!

@woshilapin woshilapin force-pushed the wsl/chore/front/remove-sentry branch from 23e7d36 to a01a37b Compare June 5, 2024 09:32
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, the app seems to be still working :)

@woshilapin woshilapin added this pull request to the merge queue Jun 17, 2024
Merged via the queue into dev with commit 2050f03 Jun 17, 2024
17 checks passed
@woshilapin woshilapin deleted the wsl/chore/front/remove-sentry branch June 17, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants