Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: refactor infra tests part 4 #7648

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented Jun 6, 2024

Part of #6980

@hamz2a hamz2a requested a review from a team as a code owner June 6, 2024 14:50
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 6 lines in your changes missing coverage. Please review.

Project coverage is 28.45%. Comparing base (93556a5) to head (3a224aa).
Report is 33 commits behind head on dev.

Files Patch % Lines
editoast/src/views/infra/errors.rs 55.55% 4 Missing ⚠️
editoast/src/modelsv2/infra/errors.rs 93.93% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7648      +/-   ##
============================================
+ Coverage     28.43%   28.45%   +0.01%     
- Complexity     2028     2038      +10     
============================================
  Files          1242     1243       +1     
  Lines        153120   153286     +166     
  Branches       3004     3008       +4     
============================================
+ Hits          43543    43618      +75     
- Misses       107789   107877      +88     
- Partials       1788     1791       +3     
Flag Coverage Δ
core 75.03% <ø> (+0.02%) ⬆️
editoast 71.86% <85.71%> (-0.01%) ⬇️
front 9.83% <ø> (-0.01%) ⬇️
gateway 2.41% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. One comment is only for confirmation, feel free to Resolve if I understood correctly. The other comment might need to track all of the occurrences in the PR.

@hamz2a hamz2a force-pushed the hai/editoast-refactor-infra-tests-part-4 branch from 242edb5 to 3a224aa Compare June 7, 2024 10:06
@hamz2a hamz2a added this pull request to the merge queue Jun 7, 2024
Merged via the queue into dev with commit 4b360d4 Jun 7, 2024
17 checks passed
@hamz2a hamz2a deleted the hai/editoast-refactor-infra-tests-part-4 branch June 7, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants