Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: refactor train schedule v2 tests #7748

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

Wadjetz
Copy link
Member

@Wadjetz Wadjetz commented Jun 17, 2024

part of #6980

@Wadjetz Wadjetz self-assigned this Jun 17, 2024
@Wadjetz Wadjetz added the area:editoast Work on Editoast Service label Jun 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 83.87097% with 5 lines in your changes missing coverage. Please review.

Project coverage is 28.61%. Comparing base (38f002e) to head (285b542).

Files Patch % Lines
editoast/src/views/v2/timetable/stdcm.rs 0.00% 2 Missing ⚠️
editoast/src/views/v2/path/pathfinding.rs 0.00% 1 Missing ⚠️
editoast/src/views/v2/path/properties.rs 0.00% 1 Missing ⚠️
editoast/src/views/v2/timetable.rs 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7748      +/-   ##
============================================
- Coverage     28.62%   28.61%   -0.01%     
  Complexity     2038     2038              
============================================
  Files          1244     1244              
  Lines        153664   153684      +20     
  Branches       3012     3012              
============================================
- Hits          43985    43978       -7     
- Misses       107888   107915      +27     
  Partials       1791     1791              
Flag Coverage Δ
core 75.05% <ø> (ø)
editoast 72.08% <83.87%> (-0.08%) ⬇️
front 9.90% <ø> (ø)
gateway 2.41% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wadjetz Wadjetz force-pushed the ebe/editoast-refactor-train-schedule-v2 branch 4 times, most recently from 2d8cf40 to 007d5a6 Compare June 18, 2024 09:39
@Wadjetz Wadjetz requested review from leovalais and woshilapin June 18, 2024 09:55
@Wadjetz Wadjetz marked this pull request as ready for review June 18, 2024 09:55
@Wadjetz Wadjetz requested a review from a team as a code owner June 18, 2024 09:55
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you 🎉

@Wadjetz Wadjetz force-pushed the ebe/editoast-refactor-train-schedule-v2 branch from 007d5a6 to c66b6db Compare June 18, 2024 12:33
@Wadjetz Wadjetz added this pull request to the merge queue Jun 19, 2024
Merged via the queue into dev with commit c02560c Jun 19, 2024
17 checks passed
@Wadjetz Wadjetz deleted the ebe/editoast-refactor-train-schedule-v2 branch June 19, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants