Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gateway: add acr_values for MFA #7817

Merged
merged 1 commit into from
Jun 26, 2024
Merged

gateway: add acr_values for MFA #7817

merged 1 commit into from
Jun 26, 2024

Conversation

younesschrifi
Copy link
Contributor

No description provided.

@younesschrifi younesschrifi requested a review from a team as a code owner June 21, 2024 13:49
@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 43 lines in your changes missing coverage. Please review.

Project coverage is 28.67%. Comparing base (24485e2) to head (94bb2e9).
Report is 12 commits behind head on dev.

Files Patch % Lines
gateway/actix_auth/src/providers/oidc.rs 0.00% 39 Missing ⚠️
gateway/src/config_parser.rs 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7817      +/-   ##
============================================
+ Coverage     28.64%   28.67%   +0.02%     
  Complexity     2058     2058              
============================================
  Files          1247     1249       +2     
  Lines        154277   154449     +172     
  Branches       3029     3040      +11     
============================================
+ Hits          44199    44285      +86     
- Misses       108277   108351      +74     
- Partials       1801     1813      +12     
Flag Coverage Δ
core 75.01% <ø> (ø)
editoast 71.96% <ø> (+0.11%) ⬆️
front 10.01% <ø> (+<0.01%) ⬆️
gateway 2.34% <0.00%> (-0.07%) ⬇️
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@younesschrifi younesschrifi force-pushed the yci/add_acr_values_oidc branch 2 times, most recently from 72b982b to 675cb12 Compare June 21, 2024 14:33
@younesschrifi younesschrifi requested a review from ElysaSrc June 21, 2024 14:36
@Khoyo
Copy link
Contributor

Khoyo commented Jun 24, 2024

This isn't an editoast commit nor PR ;)

@younesschrifi younesschrifi force-pushed the yci/add_acr_values_oidc branch 2 times, most recently from 883f26b to d824328 Compare June 25, 2024 09:54
@younesschrifi younesschrifi requested review from Khoyo and removed request for ElysaSrc June 25, 2024 09:55
@younesschrifi younesschrifi force-pushed the yci/add_acr_values_oidc branch 4 times, most recently from 4a87a7d to d8dc192 Compare June 25, 2024 12:28
@younesschrifi younesschrifi changed the title editoast: add acr_values for MFA gateway: add acr_values for MFA Jun 25, 2024
@younesschrifi younesschrifi force-pushed the yci/add_acr_values_oidc branch from d8dc192 to 2680c93 Compare June 25, 2024 15:25
@younesschrifi younesschrifi removed the request for review from Khoyo June 26, 2024 09:54
Copy link
Contributor

@bloussou bloussou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and approved ✅

@younesschrifi younesschrifi force-pushed the yci/add_acr_values_oidc branch from 8a64360 to 94bb2e9 Compare June 26, 2024 09:58
@younesschrifi younesschrifi enabled auto-merge June 26, 2024 09:59
@younesschrifi younesschrifi added this pull request to the merge queue Jun 26, 2024
Merged via the queue into dev with commit 80dbd29 Jun 26, 2024
17 checks passed
@younesschrifi younesschrifi deleted the yci/add_acr_values_oidc branch June 26, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants