core: fallback for speed limit tags #7903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7903 +/- ##
============================================
- Coverage 28.67% 28.43% -0.24%
- Complexity 2058 2075 +17
============================================
Files 1249 1264 +15
Lines 154405 155174 +769
Branches 3040 3073 +33
============================================
- Hits 44271 44123 -148
- Misses 108321 109222 +901
- Partials 1813 1829 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Erashin
reviewed
Jul 2, 2024
core/kt-osrd-rjs-parser/src/main/kotlin/fr/sncf/osrd/RawInfraRJSParser.kt
Outdated
Show resolved
Hide resolved
core/src/test/kotlin/fr/sncf/osrd/sim_infra_adapter/PathPropertiesTests.kt
Show resolved
Hide resolved
Castavo
reviewed
Jul 2, 2024
core/kt-osrd-sim-infra/src/main/kotlin/fr/sncf/osrd/sim_infra/impl/RawInfraImpl.kt
Outdated
Show resolved
Hide resolved
core/kt-osrd-rjs-parser/src/main/kotlin/fr/sncf/osrd/RawInfraRJSParser.kt
Outdated
Show resolved
Hide resolved
bougue-pe
commented
Jul 3, 2024
core/kt-osrd-sim-infra/src/main/kotlin/fr/sncf/osrd/sim_infra/impl/RawInfraImpl.kt
Show resolved
Hide resolved
Erashin
reviewed
Jul 4, 2024
core/kt-osrd-rjs-parser/src/main/kotlin/fr/sncf/osrd/RawInfraRJSParser.kt
Outdated
Show resolved
Hide resolved
Erashin
approved these changes
Jul 4, 2024
bougue-pe
force-pushed
the
peb/core/speed_limit_tag_fallback
branch
from
8c7694d to
b907320
Compare
Castavo
approved these changes
Jul 4, 2024
also: little fix on Speed.toString()
bougue-pe
force-pushed
the
peb/core/speed_limit_tag_fallback
branch
from
b907320 to
6919758
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only handling the speed for now, no work on output, warnings and logs.
Extra-code to handle long-names currently used on speedLimitTag (both in infra or in requested simu).
also: little fix on
Speed.toString()Test:
Messagerie - ME100somewhere else than South-East(to be able to select it), then using that speedLimitTag on a train to trigger fallback to MA100 on South-East.Fix #7715