Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: use workspace for version and licenses #7957

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

woshilapin
Copy link
Contributor

Just a way to add the license and versions everywhere, as a workspace feature, so only in one unique place.

@woshilapin woshilapin requested a review from a team as a code owner July 5, 2024 08:48
@woshilapin woshilapin requested a review from hamz2a July 5, 2024 08:48
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.34%. Comparing base (725b89a) to head (be8b636).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7957      +/-   ##
============================================
- Coverage     28.35%   28.34%   -0.01%     
  Complexity     2075     2075              
============================================
  Files          1270     1270              
  Lines        155669   155669              
  Branches       3076     3076              
============================================
- Hits          44135    44131       -4     
- Misses       109701   109705       +4     
  Partials       1833     1833              
Flag Coverage Δ
core 75.02% <ø> (ø)
editoast 71.26% <ø> (-0.02%) ⬇️
front 9.95% <ø> (ø)
gateway 2.34% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hamz2a hamz2a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you !

@woshilapin woshilapin added this pull request to the merge queue Jul 5, 2024
Merged via the queue into dev with commit b5e1c9d Jul 5, 2024
17 checks passed
@woshilapin woshilapin deleted the wsl/chore/editoast/workspaces branch July 5, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants