front: drop hardcoded scenario header height #7993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
commented
Jul 9, 2024
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7993 +/- ##
============================================
- Coverage 28.25% 28.24% -0.02%
Complexity 2075 2075
============================================
Files 1276 1276
Lines 156193 156190 -3
Branches 3084 3084
============================================
- Hits 44136 44115 -21
- Misses 110216 110234 +18
Partials 1841 1841
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
emersion
force-pushed
the
emersion/drop-hardcoded-size
branch
from
883e966 to
2fe805a
Compare
Uriel-Sautron
approved these changes
Jul 10, 2024
The scenario header size is hardcoded to 8rem. Replace these rules with a flexbox-based layout.
emersion
force-pushed
the
emersion/drop-hardcoded-size
branch
from
2fe805a to
9a0f302
Compare
1 task
emersion
added a commit
that referenced
this pull request
Aug 21, 2024
This is a re-do of #7993, which got reverted in #8015 because of a bug when the timetable contains lots of trains. In a flex context, the implicit default value for min-height is auto, and that prevents elements from overflowing with a scrollbar (because min-height wins against height and max-height). Override the default with "min-height: 0".
emersion
added a commit
that referenced
this pull request
Aug 29, 2024
This is a re-do of #7993, which got reverted in #8015 because of a bug when the timetable contains lots of trains. In a flex context, the implicit default value for min-height is auto, and that prevents elements from overflowing with a scrollbar (because min-height wins against height and max-height). Override the default with "min-height: 0".
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 29, 2024
This is a re-do of #7993, which got reverted in #8015 because of a bug when the timetable contains lots of trains. In a flex context, the implicit default value for min-height is auto, and that prevents elements from overflowing with a scrollbar (because min-height wins against height and max-height). Override the default with "min-height: 0".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scenario header size is hardcoded to 8rem. Replace these rules with a flexbox-based layout.