core: fix and reintroduce pathfinding heuristic #8145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8145 +/- ##
============================================
+ Coverage 28.12% 28.16% +0.03%
- Complexity 2112 2120 +8
============================================
Files 1296 1299 +3
Lines 158648 158758 +110
Branches 3164 3176 +12
============================================
+ Hits 44620 44714 +94
- Misses 112126 112141 +15
- Partials 1902 1903 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Erashin
approved these changes
Jul 23, 2024
core/src/main/kotlin/fr/sncf/osrd/api/pathfinding/PathfindingBlocksEndpoint.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/fr/sncf/osrd/api/pathfinding/RemainingDistanceEstimator.kt
Outdated
Show resolved
Hide resolved
eckter
force-pushed
the
ech/fix-heuristic
branch
from
c31b1e3 to
977dcbc
Compare
eckter
force-pushed
the
ech/fix-heuristic
branch
from
977dcbc to
e092e40
Compare
Khoyo
reviewed
Jul 23, 2024
core/src/main/kotlin/fr/sncf/osrd/api/pathfinding/PathfindingBlocksEndpoint.kt
Outdated
Show resolved
Hide resolved
It was too slow to be worth using, and needed to be adapted to return times instead of distances
eckter
force-pushed
the
ech/fix-heuristic
branch
from
e092e40 to
a9ec24c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7200
Change summary:
When running the benchmark, average process time per train goes from 40s to 25s. (note: this includes more than just the pathfinding). No extra error.
While tested I compared the old and new distance methods. The new one is less accurate, but it's not off by more than 0.1%.