-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: integrate speedspacechart version two #8146
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8146 +/- ##
============================================
+ Coverage 28.24% 28.45% +0.21%
- Complexity 2116 2123 +7
============================================
Files 1300 1301 +1
Lines 158309 157770 -539
Branches 3177 3213 +36
============================================
+ Hits 44715 44897 +182
+ Misses 111687 110935 -752
- Partials 1907 1938 +31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c7aebcc
to
34be2ec
Compare
779bb77
to
183f438
Compare
front/src/applications/operationalStudies/views/v2/SimulationResultsV2.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So nice to finally see this new chart in osrd, thank you for that !
Just started the review but here are some comments/remarks
front/src/modules/simulationResult/components/SpeedSpaceChart/SpeedSpaceChartV2.tsx
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpeedSpaceChart/SpeedSpaceChartV2.tsx
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpeedSpaceChart/SpeedSpaceChartV2.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
front/src/modules/simulationResult/components/SpeedSpaceChart/helpers.ts
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpeedSpaceChart/helpers.ts
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpeedSpaceChart/helpers.ts
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpeedSpaceChart/helpers.ts
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpeedSpaceChart/helpers.ts
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpeedSpaceChart/helpers.ts
Show resolved
Hide resolved
5b2fcf9
to
0151b31
Compare
front/src/modules/simulationResult/components/SpeedSpaceChart/helpers.ts
Outdated
Show resolved
Hide resolved
front/src/modules/powerRestriction/helpers/formatPowerRestrictionRangesWithHandled.ts
Outdated
Show resolved
Hide resolved
front/src/modules/powerRestriction/helpers/formatPowerRestrictionRangesWithHandled.ts
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpeedSpaceChart/helpers.ts
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpeedSpaceChart/helpers.ts
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpeedSpaceChart/helpers.ts
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpeedSpaceChart/helpers.ts
Outdated
Show resolved
Hide resolved
1d0209d
to
56087e8
Compare
front/src/modules/simulationResult/components/SpeedSpaceChart/__tests__/helpers.spec.ts
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpeedSpaceChart/__tests__/helpers.spec.ts
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpeedSpaceChart/d3Helpers.ts
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpeedSpaceChart/d3Helpers.ts
Show resolved
Hide resolved
front/src/modules/powerRestriction/helpers/formatPowerRestrictionRangesWithHandled.ts
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpeedSpaceChart/helpers.ts
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpeedSpaceChart/helpers.ts
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/styles/simulationResult.scss
Outdated
Show resolved
Hide resolved
front/src/applications/operationalStudies/views/v2/SimulationResultsV2.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/operationalStudies/views/v2/SimulationResultsV2.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpeedSpaceChart/SpeedSpaceChartV2.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/operationalStudies/views/v2/SimulationResultsV2.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpeedSpaceChart/helpers.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still some bugs on the speed space chart itselft (so not related to your integration PR) but Lgtm and tested, great job :)
3ec242a
to
0f5c92f
Compare
- add SpeedSpaceChart module - add format functions in /applications/operationalStudies/utils.st - add _uiSpeedSpaceChart.scss, import it in style.scss - add mmToKm() in /utils/physics.ts - isolate new logic in SpeedSpaceChartV2.tsx - adapt StdcmResultsV2.tsx to new SpeedSpaceChartV2 props - manage GEV width by retrieving container width - add translations in json files and use it in SpeedSpaceChartV2 - add tests for helpers.ts - replace declivities with slopes in translations - remove GevPreparedDataV2 type - adapt formatPowerRestrictionRangesWithHandled.ts to directly hydrate the GEV V2 - fix power restriction tests
0f5c92f
to
ab175a5
Compare
new logic
electricalProfilesDesignValues
const has been added in the same folder, in consts.tsintegration
tests
next
ui-speedspacechart needs some fixes for the GEV v2 to be well displayed (see this PR):the all height should be adapted when one or more linear layers is/are displaythe front-interactivy-layer has a uselessmt-2
tailwind rule set to!imortant
that overrides the needed cssthe settings panel height doesn't follows the GEV V2 heightspeedLimits and temporarySpeedLimits checkboxes should be disabletype: 'non_electrified'
is missing for ElectrificationValuesthe format() helpers should be testedthe width isn't responsive yetclose #7735
close #7734