front: drop tsv2 switch #8217
Merged
front: drop tsv2 switch #8217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8217 +/- ##
============================================
+ Coverage 27.18% 27.24% +0.05%
Complexity 2127 2127
============================================
Files 1310 1309 -1
Lines 157758 157328 -430
Branches 3256 3254 -2
============================================
- Hits 42887 42863 -24
+ Misses 112891 112487 -404
+ Partials 1980 1978 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SharglutDev
force-pushed
the
pfn/front/drop-tsv2-switch
branch
2 times, most recently
from
1c80d71 to
390f484
Compare
front/src/modules/trainschedule/components/ManageTrainSchedule/TrainSettings.tsx
Outdated
Show resolved
Hide resolved
SharglutDev
force-pushed
the
pfn/front/drop-tsv2-switch
branch
from
8d14ac1 to
2589d39
Compare
clarani
reviewed
Jul 29, 2024
SharglutDev
force-pushed
the
pfn/front/drop-tsv2-switch
branch
from
774cfbb to
5274097
Compare
clarani
reviewed
Jul 29, 2024
There was a problem hiding this comment.
Code looks good to me, only found 2 bugs:
- when I select a rolling stock with heating or air conditioning and reopen the rolling stock selector, then the selected rolling stock is correct but has not the correct mode (it has standard)
- when editing a rolling stock, in the effort curves tab, there is a missing translation for the air conditioning tag
|
Should be fixed :) |
clarani
reviewed
Jul 30, 2024
clarani
approved these changes
Jul 30, 2024
Operational studies and stdcm both now use tsv2 model by default
- e2e tests are now using tsv2 model - remove allowances e2e tests as they are deprecated - rolling stock comfort type properly uses tsv2 model
SharglutDev
force-pushed
the
pfn/front/drop-tsv2-switch
branch
from
7da8861 to
5cbbfb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Operational studies and stdcm both now use tsv2 model by default
e2e tests have been adapted and some removed (see 2nd commit) in accordance with @Maymanaf
close #8059