-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: drop simulation results and stdcm v1 #8269
front: drop simulation results and stdcm v1 #8269
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8269 +/- ##
============================================
+ Coverage 27.48% 36.11% +8.63%
Complexity 2155 2155
============================================
Files 1316 1282 -34
Lines 158162 119478 -38684
Branches 3262 3211 -51
============================================
- Hits 43469 43153 -316
+ Misses 112710 74393 -38317
+ Partials 1983 1932 -51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job !
You can also remove :
- ORSD_GRAPH_SAMPLE_DATA (in sample.ts)
- all the rotate props
- the function getSimulationResults
- the function onlyDigit
- spaceTimeChart/types.ts
front/src/modules/simulationResult/components/SpaceTimeChart/useStoreDataForSpaceTimeChart.ts
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpaceTimeChart/useStoreDataForSpaceTimeChart.ts
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpeedSpaceChart/SpeedSpaceChart.tsx
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpeedSpaceChart/SpeedSpaceSettings.tsx
Show resolved
Hide resolved
front/src/modules/simulationResult/components/ChartHelpers/defineChart.ts
Show resolved
Hide resolved
front/src/modules/simulationResult/components/ChartHelpers/ChartHelpers.ts
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/ChartHelpers/enableInteractivity.tsx
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpeedSpaceChart/utils.ts
Outdated
Show resolved
Hide resolved
Done for ORSD_GRAPH_SAMPLE_DATA, getSimulationResults, onlyDigit, spaceTimeChart/types.ts. For all the rotates, I started to do it but I thought that if rotate is implemented in the new spacetime and speedspace charts and if we still want to keep the spaceCurvesSlopes chart, we might maybe need it ? Since it will be a lot of work to remove all of them in the chart utils and in enableInteractivity if we are not sure to drop them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM & tested ✅
It's fine for me if we keep the rotate for the moment 👍
bdfbd6f
to
21c834c
Compare
close #8060
close #8238
This PR doesn't not handle removing V2 names, it will done in a different one.
To test :