Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: drop simulation results and stdcm v1 #8269

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

SharglutDev
Copy link
Contributor

@SharglutDev SharglutDev commented Jul 31, 2024

close #8060
close #8238

This PR doesn't not handle removing V2 names, it will done in a different one.

To test :

  • simulation results v2 work properly
  • synchro is still here between spaceCurvesSlopes chart, map (train moving) and the topbar with trainpositions
  • stdcm debug still working
  • no errors in console

@SharglutDev SharglutDev requested a review from a team as a code owner July 31, 2024 15:13
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 2.68456% with 145 lines in your changes missing coverage. Please review.

Project coverage is 36.11%. Comparing base (34c0b8e) to head (21c834c).
Report is 1 commits behind head on dev.

Files Patch % Lines
...lationResult/components/SpaceCurvesSlopes/utils.ts 0.00% 69 Missing and 1 partial ⚠️
...lt/components/ChartHelpers/enableInteractivity.tsx 0.00% 33 Missing ⚠️
...mponents/SpaceCurvesSlopes/SpaceCurvesSlopesV2.tsx 0.00% 7 Missing ⚠️
...tudies/components/Scenario/getSimulationResults.ts 0.00% 3 Missing and 1 partial ⚠️
...ationResult/components/ChartHelpers/defineChart.ts 0.00% 4 Missing ⚠️
...plications/operationalStudies/views/ScenarioV1.tsx 0.00% 3 Missing ⚠️
...perationalStudies/views/v2/SimulationResultsV2.tsx 0.00% 2 Missing ⚠️
...t/src/common/Map/WarpedMap/SimulationWarpedMap.tsx 0.00% 2 Missing ⚠️
...mulationResult/components/ChartHelpers/drawArea.ts 0.00% 2 Missing ⚠️
...ulationResult/components/ChartHelpers/drawCurve.ts 0.00% 2 Missing ⚠️
... and 13 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8269      +/-   ##
============================================
+ Coverage     27.48%   36.11%   +8.63%     
  Complexity     2155     2155              
============================================
  Files          1316     1282      -34     
  Lines        158162   119478   -38684     
  Branches       3262     3211      -51     
============================================
- Hits          43469    43153     -316     
+ Misses       112710    74393   -38317     
+ Partials       1983     1932      -51     
Flag Coverage Δ
core 75.53% <ø> (ø)
editoast 64.60% <ø> (-0.05%) ⬇️
front 15.68% <2.68%> (+5.23%) ⬆️
gateway 2.03% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SharglutDev SharglutDev requested review from Yohh and clarani July 31, 2024 15:22
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job !

You can also remove :

  • ORSD_GRAPH_SAMPLE_DATA (in sample.ts)
  • all the rotate props
  • the function getSimulationResults
  • the function onlyDigit
  • spaceTimeChart/types.ts

@SharglutDev
Copy link
Contributor Author

Nice job !

You can also remove :

* [ ]  ORSD_GRAPH_SAMPLE_DATA (in sample.ts)

* [ ]  all the rotate props

* [ ]  the function getSimulationResults

* [ ]  the function onlyDigit

* [ ]  spaceTimeChart/types.ts

Done for ORSD_GRAPH_SAMPLE_DATA, getSimulationResults, onlyDigit, spaceTimeChart/types.ts.

For all the rotates, I started to do it but I thought that if rotate is implemented in the new spacetime and speedspace charts and if we still want to keep the spaceCurvesSlopes chart, we might maybe need it ? Since it will be a lot of work to remove all of them in the chart utils and in enableInteractivity if we are not sure to drop them.

@SharglutDev SharglutDev requested a review from clarani August 2, 2024 07:45
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & tested ✅

It's fine for me if we keep the rotate for the moment 👍

@SharglutDev SharglutDev force-pushed the pfn/front/drop-simulations-results-and-stdcm-v1 branch from bdfbd6f to 21c834c Compare August 2, 2024 08:30
@SharglutDev SharglutDev enabled auto-merge August 2, 2024 08:33
@SharglutDev SharglutDev added this pull request to the merge queue Aug 2, 2024
Merged via the queue into dev with commit 8f345ad Aug 2, 2024
20 checks passed
@SharglutDev SharglutDev deleted the pfn/front/drop-simulations-results-and-stdcm-v1 branch August 2, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop Stdcm v1 Drop Simulation Results V1
3 participants