editoast: implement Authorizer creation middleware #8319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leovalais
force-pushed
the
authorizer-middleware
branch
from
5c71392 to
457a29b
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8319 +/- ##
=========================================
Coverage 36.73% 36.74%
Complexity 2163 2163
=========================================
Files 1282 1282
Lines 119626 119651 +25
Branches 3218 3226 +8
=========================================
+ Hits 43943 43962 +19
+ Misses 73752 73750 -2
- Partials 1931 1939 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
leovalais
force-pushed
the
authorizer-middleware
branch
5 times, most recently
from
0ed793d to
52a6dde
Compare
Co-Authored-By: Younes Khoudli <[email protected]>
leovalais
force-pushed
the
authorizer-middleware
branch
from
52a6dde to
f7d3090
Compare
Wadjetz
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Half of the axum server is in
main.rsand the rest inviews/mod.rs. We'll need to homogenize that.We removed the lazy role fetching and caching as this would require internal mutability since the
Authorizernow lives in anArc. Instead, we now fetch the roles when theAuthorizeris initialized.Closes #8276