-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: using config stored in db for stdcm v2 #8336
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8336 +/- ##
============================================
+ Coverage 37.07% 37.49% +0.41%
Complexity 2165 2165
============================================
Files 1265 1253 -12
Lines 117058 115653 -1405
Branches 3137 3139 +2
============================================
- Hits 43404 43366 -38
+ Misses 71814 70445 -1369
- Partials 1840 1842 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
335c318
to
507f923
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR.
fb5886e
to
f736a75
Compare
b86c1c5
to
823d88c
Compare
front/src/applications/stdcmV2/components/StdcmEmptyConfigError.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/stdcmV2/components/StdcmEmptyConfigError.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM & tested ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test part is ✅
I squashed my commits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fix #8239
To test it, you need to insert a row in the table
stdcm_search_environment