Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: using config stored in db for stdcm v2 #8336

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Conversation

sim51
Copy link
Contributor

@sim51 sim51 commented Aug 5, 2024

Fix #8239

To test it, you need to insert a row in the table stdcm_search_environment

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 2.43902% with 200 lines in your changes missing coverage. Please review.

Project coverage is 37.49%. Comparing base (39e7b9d) to head (b1d22a4).

Files Patch % Lines
...ont/src/applications/stdcmV2/hooks/useStdcmEnv.tsx 0.00% 49 Missing and 1 partial ⚠️
...ont/src/applications/stdcmV2/views/StdcmViewV2.tsx 0.00% 35 Missing ⚠️
.../src/applications/stdcm/utils/formatStdcmConfV2.ts 0.00% 27 Missing ⚠️
...rc/applications/stdcmV2/components/StdcmOrigin.tsx 0.00% 26 Missing and 1 partial ⚠️
...tions/stdcmV2/components/StdcmEmptyConfigError.tsx 0.00% 20 Missing and 1 partial ⚠️
front/src/reducers/osrdconf/stdcmConf/index.ts 5.26% 18 Missing ⚠️
editoast/src/views/v2/timetable/stdcm.rs 0.00% 15 Missing ⚠️
...rc/applications/stdcmV2/components/StdcmHeader.tsx 0.00% 6 Missing ⚠️
.../src/reducers/osrdconf/osrdConfCommon/selectors.ts 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8336      +/-   ##
============================================
+ Coverage     37.07%   37.49%   +0.41%     
  Complexity     2165     2165              
============================================
  Files          1265     1253      -12     
  Lines        117058   115653    -1405     
  Branches       3137     3139       +2     
============================================
- Hits          43404    43366      -38     
+ Misses        71814    70445    -1369     
- Partials       1840     1842       +2     
Flag Coverage Δ
core 74.94% <ø> (ø)
editoast 66.38% <0.00%> (-0.04%) ⬇️
front 15.77% <1.59%> (-0.03%) ⬇️
gateway ?
osrdyne 2.71% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 73.00% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sim51 sim51 force-pushed the bsi/issue-8239-2 branch 2 times, most recently from 335c318 to 507f923 Compare August 5, 2024 15:55
@sim51 sim51 marked this pull request as ready for review August 5, 2024 15:59
@sim51 sim51 requested review from a team as code owners August 5, 2024 15:59
@sim51 sim51 force-pushed the bsi/issue-8239-2 branch from 507f923 to 0ef87e0 Compare August 5, 2024 16:03
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR.

@sim51 sim51 requested a review from kmer2016 August 6, 2024 15:08
@sim51 sim51 force-pushed the bsi/issue-8239-2 branch 2 times, most recently from fb5886e to f736a75 Compare August 6, 2024 15:32
@sim51 sim51 requested a review from a team as a code owner August 6, 2024 15:32
@sim51 sim51 requested a review from bloussou August 6, 2024 15:32
@sim51 sim51 force-pushed the bsi/issue-8239-2 branch 2 times, most recently from b86c1c5 to 823d88c Compare August 7, 2024 07:54
@sim51 sim51 requested review from clarani and flomonster August 8, 2024 11:35
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & tested ✅

Copy link
Contributor

@bloussou bloussou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test part is ✅

@sim51 sim51 force-pushed the bsi/issue-8239-2 branch from a742167 to 430d7b2 Compare August 9, 2024 15:33
@sim51
Copy link
Contributor Author

sim51 commented Aug 9, 2024

I squashed my commits

@sim51 sim51 enabled auto-merge August 9, 2024 15:33
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sim51 sim51 force-pushed the bsi/issue-8239-2 branch from 430d7b2 to bf57291 Compare August 9, 2024 17:55
@sim51 sim51 force-pushed the bsi/issue-8239-2 branch from bf57291 to b1d22a4 Compare August 9, 2024 18:39
@sim51 sim51 added this pull request to the merge queue Aug 9, 2024
Merged via the queue into dev with commit c268b4a Aug 9, 2024
22 checks passed
@sim51 sim51 deleted the bsi/issue-8239-2 branch August 9, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: update stdcm page to use the stdcm search env configured in the db
5 participants