Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: highlight selected train in GET #8405

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

Uriel-Sautron
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron requested a review from a team as a code owner August 9, 2024 11:30
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 37.03%. Comparing base (f96793d) to head (dcda29e).

Files Patch % Lines
...s/stdcmV2/components/StdcmResults/StdcmUpgrade.tsx 0.00% 4 Missing ⚠️
...ations/stdcm/utils/formatStdcmIntoSpaceTimeData.ts 0.00% 2 Missing ⚠️
...perationalStudies/views/v2/SimulationResultsV2.tsx 0.00% 1 Missing ⚠️
...rationalStudies/views/v2/getSimulationResultsV2.ts 0.00% 1 Missing ⚠️
...rc/applications/stdcm/utils/formatSpaceTimeData.ts 0.00% 1 Missing ⚠️
...s/stdcmV2/components/StdcmResults/StdcmResults.tsx 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8405      +/-   ##
============================================
- Coverage     37.03%   37.03%   -0.01%     
  Complexity     2165     2165              
============================================
  Files          1267     1267              
  Lines        117203   117204       +1     
  Branches       3139     3139              
============================================
- Hits          43410    43405       -5     
- Misses        71951    71957       +6     
  Partials       1842     1842              
Flag Coverage Δ
core 74.94% <ø> (ø)
editoast 66.40% <ø> (-0.02%) ⬇️
front 15.77% <0.00%> (-0.01%) ⬇️
gateway 2.20% <ø> (ø)
osrdyne 2.71% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 73.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Uriel-Sautron Uriel-Sautron force-pushed the usn/get-highlight-selected-train branch from ba2adbf to 28bd5e5 Compare August 9, 2024 11:58
@Uriel-Sautron Uriel-Sautron requested a review from clarani August 9, 2024 14:30
@Uriel-Sautron Uriel-Sautron force-pushed the usn/get-highlight-selected-train branch from 28bd5e5 to 19867bb Compare August 9, 2024 15:03
Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested

@Uriel-Sautron Uriel-Sautron force-pushed the usn/get-highlight-selected-train branch from 19867bb to 00176eb Compare August 12, 2024 08:39
@Uriel-Sautron Uriel-Sautron requested a review from theocrsb August 12, 2024 09:22
@Uriel-Sautron Uriel-Sautron requested a review from clarani August 13, 2024 12:46
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & tested ✅

  - create function to format space time data
  - add selected train id in manchette's props

  - add test for formatSpaceTimeDataToProjectPathTrainResult

  - add the missing prop onClick to the button

Revert "  - add test for formatSpaceTimeDataToProjectPathTrainResult"

This reverts commit 00176eb.

  - change type TrainSpaceTimeData (trainName -> name)
  - remove formatSpaceTimeDataToProjectPathTrainResult function
@Uriel-Sautron Uriel-Sautron force-pushed the usn/get-highlight-selected-train branch from 65a7681 to dcda29e Compare August 13, 2024 13:28
@Uriel-Sautron Uriel-Sautron added this pull request to the merge queue Aug 13, 2024
Merged via the queue into dev with commit 30889aa Aug 13, 2024
22 checks passed
@Uriel-Sautron Uriel-Sautron deleted the usn/get-highlight-selected-train branch August 13, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GET: Highlight the selected train
4 participants