Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: add roles checks to documents and electrical profiles api #8425

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

Wadjetz
Copy link
Member

@Wadjetz Wadjetz commented Aug 12, 2024

No description provided.

@Wadjetz Wadjetz self-assigned this Aug 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 72.72727% with 18 lines in your changes missing coverage. Please review.

Project coverage is 36.94%. Comparing base (8245ae5) to head (d0189e6).
Report is 20 commits behind head on dev.

Files with missing lines Patch % Lines
editoast/src/views/electrical_profiles.rs 75.00% 10 Missing ⚠️
editoast/src/views/documents.rs 75.00% 6 Missing ⚠️
editoast/editoast_authz/src/builtin_role.rs 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8425      +/-   ##
============================================
+ Coverage     36.91%   36.94%   +0.02%     
  Complexity     2175     2175              
============================================
  Files          1279     1279              
  Lines        118972   119038      +66     
  Branches       3188     3188              
============================================
+ Hits          43915    43974      +59     
- Misses        73172    73179       +7     
  Partials       1885     1885              
Flag Coverage Δ
core 74.87% <ø> (ø)
editoast 66.22% <72.72%> (+0.04%) ⬆️
front 15.84% <ø> (ø)
gateway 2.20% <ø> (ø)
osrdyne 2.71% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wadjetz Wadjetz marked this pull request as ready for review August 12, 2024 15:21
@Wadjetz Wadjetz requested a review from a team as a code owner August 12, 2024 15:21
@Wadjetz Wadjetz requested review from flomonster and hamz2a August 13, 2024 07:35
Copy link
Contributor

@hamz2a hamz2a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Wadjetz Wadjetz changed the title editoast: add roles checks to documents api editoast: add roles checks to documents and electrical profiles api Aug 13, 2024
@Wadjetz Wadjetz requested a review from Tguisnet August 14, 2024 07:32
@Wadjetz Wadjetz force-pushed the ebe/editoast-add-roles-to-documents branch from b54b3cd to d0189e6 Compare August 29, 2024 14:32
@Wadjetz Wadjetz requested a review from leovalais August 29, 2024 14:32
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Wadjetz Wadjetz added this pull request to the merge queue Aug 30, 2024
Merged via the queue into dev with commit d6d4cb3 Aug 30, 2024
22 checks passed
@Wadjetz Wadjetz deleted the ebe/editoast-add-roles-to-documents branch August 30, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants