Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: reset the pathStep properties instead of deleting the pathStep #8438

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

theocrsb
Copy link
Contributor

Close #8164 but we don't have an 'eraser' logo. I have opened a new ticket.
And this PR should also fix this comment

@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 43 lines in your changes missing coverage. Please review.

Project coverage is 36.93%. Comparing base (5a1be08) to head (9368ee3).
Report is 1 commits behind head on dev.

Files Patch % Lines
front/src/modules/timesStops/TimesStopsInput.tsx 0.00% 43 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8438      +/-   ##
============================================
- Coverage     36.94%   36.93%   -0.02%     
  Complexity     2168     2168              
============================================
  Files          1271     1271              
  Lines        117906   117921      +15     
  Branches       3164     3164              
============================================
- Hits          43565    43553      -12     
- Misses        72475    72502      +27     
  Partials       1866     1866              
Flag Coverage Δ
core 74.96% <ø> (ø)
editoast 66.37% <ø> (-0.04%) ⬇️
front 15.84% <0.00%> (-0.01%) ⬇️
gateway 2.20% <ø> (ø)
osrdyne 2.71% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works well. For the bug to which this PR is linked, this closes it well since it is no longer reproducible.

@theocrsb theocrsb force-pushed the tce/front/trainschedule/bug-order-input branch from 1c23a29 to 7ba0aac Compare August 14, 2024 10:51
Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine to me. However, I'm not sure if it's intentional, but when the pathStep is erased, the information is deleted, yet the icon remains. Was this the intended behavior?

@theocrsb
Copy link
Contributor Author

The code looks fine to me. However, I'm not sure if it's intentional, but when the pathStep is erased, the information is deleted, yet the icon remains. Was this the intended behavior?

After talking with @Tguisnet. We think it's better to remove the cross when everything is clear.

@theocrsb theocrsb force-pushed the tce/front/trainschedule/bug-order-input branch 3 times, most recently from 47c12d0 to d711057 Compare August 16, 2024 06:16
@theocrsb theocrsb requested review from kmer2016 and Akctarus August 16, 2024 06:19
Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested

@kmer2016 kmer2016 enabled auto-merge August 16, 2024 07:46
@kmer2016 kmer2016 disabled auto-merge August 16, 2024 07:47
@theocrsb theocrsb force-pushed the tce/front/trainschedule/bug-order-input branch from d711057 to 9368ee3 Compare August 16, 2024 07:48
@theocrsb theocrsb enabled auto-merge August 16, 2024 07:48
@theocrsb theocrsb added this pull request to the merge queue Aug 16, 2024
Merged via the queue into dev with commit 42aa0d3 Aug 16, 2024
22 checks passed
@theocrsb theocrsb deleted the tce/front/trainschedule/bug-order-input branch August 16, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schedule table: replace ❌ icon to an eraser and change it's behavior
4 participants