-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: reset the pathStep properties instead of deleting the pathStep #8438
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8438 +/- ##
============================================
- Coverage 36.94% 36.93% -0.02%
Complexity 2168 2168
============================================
Files 1271 1271
Lines 117906 117921 +15
Branches 3164 3164
============================================
- Hits 43565 43553 -12
- Misses 72475 72502 +27
Partials 1866 1866
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, works well. For the bug to which this PR is linked, this closes it well since it is no longer reproducible.
1c23a29
to
7ba0aac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks fine to me. However, I'm not sure if it's intentional, but when the pathStep is erased, the information is deleted, yet the icon remains. Was this the intended behavior?
After talking with @Tguisnet. We think it's better to remove the cross when everything is clear. |
47c12d0
to
d711057
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tested
d711057
to
9368ee3
Compare
Close #8164 but we don't have an 'eraser' logo. I have opened a new ticket.
And this PR should also fix this comment