Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: add roles check to views::timetable #8445

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented Aug 14, 2024

Part of #8446

@hamz2a hamz2a requested a review from a team as a code owner August 14, 2024 08:35
@hamz2a hamz2a requested review from Wadjetz and flomonster August 14, 2024 08:36
@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 60.41667% with 19 lines in your changes missing coverage. Please review.

Project coverage is 36.83%. Comparing base (7a8685f) to head (f0e6625).
Report is 1 commits behind head on dev.

Files Patch % Lines
editoast/src/views/v2/timetable.rs 63.04% 17 Missing ⚠️
editoast/editoast_authz/src/builtin_role.rs 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8445      +/-   ##
============================================
- Coverage     36.83%   36.83%   -0.01%     
  Complexity     2169     2169              
============================================
  Files          1280     1280              
  Lines        118631   118678      +47     
  Branches       3184     3184              
============================================
+ Hits          43694    43710      +16     
- Misses        73054    73085      +31     
  Partials       1883     1883              
Flag Coverage Δ
core 74.86% <ø> (ø)
editoast 66.12% <60.41%> (-0.05%) ⬇️
front 15.84% <ø> (ø)
gateway 2.20% <ø> (ø)
osrdyne 2.71% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamz2a hamz2a requested a review from leovalais August 16, 2024 08:26
@hamz2a hamz2a force-pushed the hai/editoast-add-roles-check-to-views-timetable branch from 442a4f8 to ae1e4ab Compare August 21, 2024 08:31
@hamz2a hamz2a requested a review from leovalais August 21, 2024 08:32
@hamz2a hamz2a force-pushed the hai/editoast-add-roles-check-to-views-timetable branch from ae1e4ab to f0e6625 Compare August 21, 2024 13:31
@hamz2a hamz2a added this pull request to the merge queue Aug 21, 2024
Merged via the queue into dev with commit b58bc6b Aug 21, 2024
22 checks passed
@hamz2a hamz2a deleted the hai/editoast-add-roles-check-to-views-timetable branch August 21, 2024 13:57
@hamz2a hamz2a mentioned this pull request Aug 21, 2024
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants