Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: add roles check to views::v2::path::pathfinding #8449

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented Aug 14, 2024

Part of #8446

@hamz2a hamz2a requested a review from a team as a code owner August 14, 2024 10:08
@hamz2a hamz2a requested review from Wadjetz and flomonster August 14, 2024 10:08
@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 37.03%. Comparing base (ab7706e) to head (ea2a91c).
Report is 34 commits behind head on dev.

Files Patch % Lines
editoast/src/views/v2/path/pathfinding.rs 0.00% 8 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8449      +/-   ##
============================================
- Coverage     37.04%   37.03%   -0.01%     
  Complexity     2165     2165              
============================================
  Files          1267     1267              
  Lines        117208   117216       +8     
  Branches       3139     3139              
============================================
- Hits          43414    43413       -1     
- Misses        71952    71961       +9     
  Partials       1842     1842              
Flag Coverage Δ
core 74.94% <ø> (ø)
editoast 66.39% <0.00%> (-0.03%) ⬇️
front 15.78% <ø> (ø)
gateway 2.20% <ø> (ø)
osrdyne 2.71% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 73.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamz2a hamz2a requested a review from leovalais August 16, 2024 08:26
@hamz2a hamz2a added this pull request to the merge queue Aug 20, 2024
Merged via the queue into dev with commit 0c7b11a Aug 20, 2024
22 checks passed
@hamz2a hamz2a deleted the hai/editoast-add-roles-check-to-views-path-pathfinding branch August 20, 2024 16:14
@hamz2a hamz2a mentioned this pull request Aug 21, 2024
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants