Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: add roles check to views::sprites #8510

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented Aug 21, 2024

Part of #8446

@hamz2a hamz2a requested a review from a team as a code owner August 21, 2024 08:46
@hamz2a hamz2a requested review from Wadjetz and leovalais August 21, 2024 08:47
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.

Project coverage is 36.97%. Comparing base (819e1e8) to head (c9c16c8).
Report is 23 commits behind head on dev.

Files Patch % Lines
editoast/src/views/sprites.rs 77.77% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #8510   +/-   ##
=========================================
  Coverage     36.96%   36.97%           
  Complexity     2168     2168           
=========================================
  Files          1271     1271           
  Lines        118097   118114   +17     
  Branches       3174     3174           
=========================================
+ Hits          43656    43670   +14     
- Misses        72566    72569    +3     
  Partials       1875     1875           
Flag Coverage Δ
core 74.90% <ø> (ø)
editoast 66.16% <77.77%> (+<0.01%) ⬆️
front 15.95% <ø> (ø)
gateway 2.20% <ø> (ø)
osrdyne 2.71% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamz2a hamz2a added this pull request to the merge queue Aug 21, 2024
Merged via the queue into dev with commit 7a8685f Aug 21, 2024
22 checks passed
@hamz2a hamz2a deleted the hai/editoast-add-roles-check-to-views-sprites branch August 21, 2024 13:24
@hamz2a hamz2a mentioned this pull request Aug 21, 2024
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants