-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove v2 suffix #8526
Remove v2 suffix #8526
Conversation
a0a4b16
to
0587cd8
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8526 +/- ##
============================================
- Coverage 36.91% 36.89% -0.03%
+ Complexity 2213 2208 -5
============================================
Files 1255 1255
Lines 114139 114105 -34
Branches 3188 3188
============================================
- Hits 42140 42104 -36
- Misses 70104 70106 +2
Partials 1895 1895
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
95b5b02
to
af0d937
Compare
20adb70
to
873f7e1
Compare
af0d937
to
300d492
Compare
dc55996
to
f7b9ae4
Compare
4439768
to
c3fc739
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really mind the suffix, but LGTM for tests/, assuming they pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR, v1 almost gone :) Just one comment and it's good to go for me !
front/src/modules/scenario/components/ScenarioExplorer/ScenarioExplorer.tsx
Outdated
Show resolved
Hide resolved
3fe3612
to
cd4701c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
we resolved @woshilapin comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
de1ea87
to
1323950
Compare
a23686d
to
f4793f0
Compare
f4793f0
to
e0fb6d9
Compare
Close #8265