Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove v2 suffix #8526

Merged
merged 5 commits into from
Sep 5, 2024
Merged

Remove v2 suffix #8526

merged 5 commits into from
Sep 5, 2024

Conversation

younesschrifi
Copy link
Contributor

@younesschrifi younesschrifi commented Aug 22, 2024

Close #8265

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 77.34488% with 157 lines in your changes missing coverage. Please review.

Project coverage is 36.89%. Comparing base (615f035) to head (e0fb6d9).
Report is 9 commits behind head on dev.

Files with missing lines Patch % Lines
front/src/common/api/generatedEditoastApi.ts 91.53% 38 Missing ⚠️
...les/scenario/components/AddOrEditScenarioModal.tsx 0.00% 14 Missing ⚠️
...o/components/ScenarioExplorer/ScenarioExplorer.tsx 0.00% 12 Missing ⚠️
...nt/src/modules/pathfinding/hooks/usePathfinding.ts 22.22% 7 Missing ⚠️
...alStudies/hooks/useSetupItineraryForTrainUpdate.ts 25.00% 6 Missing ⚠️
...ationalStudies/components/MacroEditor/ngeToOsrd.ts 0.00% 4 Missing ⚠️
...ations/operationalStudies/hooks/useScenarioData.ts 0.00% 4 Missing ⚠️
...nt/src/applications/stdcm/hooks/useStdcmResults.ts 0.00% 4 Missing ⚠️
...TimeChart/useGetProjectedTrainOperationalPoints.ts 0.00% 4 Missing ⚠️
...ions/operationalStudies/hooks/useLazyLoadTrains.ts 0.00% 3 Missing ⚠️
... and 31 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8526      +/-   ##
============================================
- Coverage     36.91%   36.89%   -0.03%     
+ Complexity     2213     2208       -5     
============================================
  Files          1255     1255              
  Lines        114139   114105      -34     
  Branches       3188     3188              
============================================
- Hits          42140    42104      -36     
- Misses        70104    70106       +2     
  Partials       1895     1895              
Flag Coverage Δ
core 74.73% <ø> (-0.03%) ⬇️
editoast 72.05% <98.14%> (-0.03%) ⬇️
front 14.92% <73.84%> (-0.01%) ⬇️
gateway 2.20% <ø> (ø)
osrdyne 2.71% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.37% <94.44%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@younesschrifi younesschrifi force-pushed the yci/remove-v2-suffix branch 6 times, most recently from 95b5b02 to af0d937 Compare August 22, 2024 22:31
@younesschrifi younesschrifi force-pushed the yci/delete-tsv1-endpoint branch from 20adb70 to 873f7e1 Compare August 22, 2024 22:35
@younesschrifi younesschrifi force-pushed the yci/delete-tsv1-endpoint branch 6 times, most recently from dc55996 to f7b9ae4 Compare August 29, 2024 14:53
Base automatically changed from yci/delete-tsv1-endpoint to dev August 29, 2024 15:40
@younesschrifi younesschrifi force-pushed the yci/remove-v2-suffix branch 6 times, most recently from 4439768 to c3fc739 Compare September 3, 2024 11:40
@younesschrifi younesschrifi marked this pull request as ready for review September 3, 2024 11:40
@younesschrifi younesschrifi requested review from a team as code owners September 3, 2024 11:40
Copy link
Contributor

@shenriotpro shenriotpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really mind the suffix, but LGTM for tests/, assuming they pass

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR, v1 almost gone :) Just one comment and it's good to go for me !

@younesschrifi younesschrifi force-pushed the yci/remove-v2-suffix branch 5 times, most recently from 3fe3612 to cd4701c Compare September 4, 2024 07:59
Copy link
Contributor

@Tguisnet Tguisnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

we resolved @woshilapin comment.

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@younesschrifi younesschrifi force-pushed the yci/remove-v2-suffix branch 7 times, most recently from de1ea87 to 1323950 Compare September 4, 2024 16:18
@younesschrifi younesschrifi force-pushed the yci/remove-v2-suffix branch 3 times, most recently from a23686d to f4793f0 Compare September 5, 2024 10:00
@younesschrifi younesschrifi added this pull request to the merge queue Sep 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 5, 2024
@younesschrifi younesschrifi added this pull request to the merge queue Sep 5, 2024
Merged via the queue into dev with commit 5e3ca65 Sep 5, 2024
22 checks passed
@younesschrifi younesschrifi deleted the yci/remove-v2-suffix branch September 5, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DROP TSV1: drop "v2" from editoast
8 participants