Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: allow to edit invalid trains without rolling stock name #8531

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Aug 22, 2024

The user couldn't see the configuration of an invalid train without rolling stock name because of an early return.

closes #8530

@clarani clarani requested a review from a team as a code owner August 22, 2024 09:02
@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 36.84%. Comparing base (e5ceb84) to head (ae118e6).
Report is 10 commits behind head on dev.

Files Patch % Lines
...alStudies/hooks/useSetupItineraryForTrainUpdate.ts 0.00% 24 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8531      +/-   ##
============================================
- Coverage     36.85%   36.84%   -0.02%     
- Complexity     2169     2172       +3     
============================================
  Files          1280     1280              
  Lines        118739   118785      +46     
  Branches       3184     3184              
============================================
+ Hits          43764    43766       +2     
- Misses        73092    73136      +44     
  Partials       1883     1883              
Flag Coverage Δ
core 74.88% <ø> (+0.02%) ⬆️
editoast 66.07% <ø> (-0.10%) ⬇️
front 15.85% <0.00%> (+<0.01%) ⬆️
gateway 2.20% <ø> (ø)
osrdyne 2.71% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works

Feel free to resolve the comment

The user couldn't see the configuration of an invalid train without rolling stock name because of an early return.
@clarani clarani force-pushed the cni/8530-allow-invalid-train-edition branch from b00a4ef to ae118e6 Compare August 22, 2024 09:48
Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested

@clarani clarani enabled auto-merge August 22, 2024 09:56
@clarani clarani added this pull request to the merge queue Aug 22, 2024
Merged via the queue into dev with commit 77ed9b9 Aug 22, 2024
22 checks passed
@clarani clarani deleted the cni/8530-allow-invalid-train-edition branch August 22, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input fields of invalid train are not updated
4 participants