Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: highlight selected train in space time chart #8566

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

Uriel-Sautron
Copy link
Contributor

close #8565

@Uriel-Sautron Uriel-Sautron requested a review from a team as a code owner August 23, 2024 10:40
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 36.83%. Comparing base (08b79b8) to head (5f1db18).

Files Patch % Lines
...perationalStudies/views/v2/SimulationResultsV2.tsx 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8566      +/-   ##
============================================
- Coverage     36.84%   36.83%   -0.01%     
  Complexity     2175     2175              
============================================
  Files          1280     1280              
  Lines        118809   118810       +1     
  Branches       3189     3189              
============================================
- Hits          43776    43765      -11     
- Misses        73147    73159      +12     
  Partials       1886     1886              
Flag Coverage Δ
core 74.87% <ø> (ø)
editoast 66.06% <ø> (-0.04%) ⬇️
front 15.84% <0.00%> (-0.01%) ⬇️
gateway 2.20% <ø> (ø)
osrdyne 2.71% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested !

Copy link
Contributor

@Caracol3 Caracol3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (tested)

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅ (sorry for the bug 😬 )

@Uriel-Sautron Uriel-Sautron added this pull request to the merge queue Aug 23, 2024
Merged via the queue into dev with commit 187b095 Aug 23, 2024
22 checks passed
@Uriel-Sautron Uriel-Sautron deleted the usn/no-highlight-selected-train branch August 23, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GET: no highlight on selected train
5 participants