front: make ch check more robust in updatePathStepsFromOperationalPoints() #8631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nts()
The PathItemLocation type definition allows for null secondary_code
such as:
{ uic: 42, secondary_code: null }
and this is equivalent to:
{ uic: 42 }
Make the logic more future-proof by checking whether the property
is truthy instead of checking if step has a secondary_code property.
SharglutDev
approved these changes
Aug 30, 2024
anisometropie
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PathItemLocation type definition allows for null secondary_code such as:
and this is equivalent to:
Make the logic more future-proof by checking whether the property is truthy instead of checking if step has a secondary_code property.