Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old pagination system of editoast #8662

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Conversation

leovalais
Copy link
Contributor

We had to wait for the removal of TSV1 and here we are.

@leovalais leovalais requested a review from a team as a code owner August 30, 2024 16:08
@leovalais leovalais requested a review from Castavo August 30, 2024 16:09
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.87%. Comparing base (7137459) to head (7366f5d).
Report is 15 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8662      +/-   ##
============================================
- Coverage     36.87%   36.87%   -0.01%     
  Complexity     2177     2177              
============================================
  Files          1255     1255              
  Lines        113689   113709      +20     
  Branches       3203     3203              
============================================
+ Hits          41928    41935       +7     
- Misses        69866    69879      +13     
  Partials       1895     1895              
Flag Coverage Δ
core 74.79% <ø> (ø)
editoast 71.75% <ø> (+<0.01%) ⬆️
front 14.96% <ø> (-0.01%) ⬇️
gateway 2.20% <ø> (ø)
osrdyne 2.71% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leovalais leovalais enabled auto-merge August 30, 2024 16:16
Copy link
Contributor

@Castavo Castavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leovalais leovalais added this pull request to the merge queue Sep 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 2, 2024
@leovalais leovalais added this pull request to the merge queue Sep 2, 2024
Merged via the queue into dev with commit 43a9891 Sep 2, 2024
22 checks passed
@leovalais leovalais deleted the lva/remove-old-pagination branch September 2, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants