front: add eslint rule to ban React.FC

[clarani]

closes #8663

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 11.55556% with 199 lines in your changes missing coverage. Please review.

Project coverage is 36.83%. Comparing base (074ce44) to head (9655fc9).
Report is 15 commits behind head on dev.

Files with missing lines	Patch %	Lines
...r/tools/pointEdition/components/CustomPosition.tsx	0.00%	16 Missing ⚠️
...src/applications/editor/components/EntitySumUp.tsx	0.00%	10 Missing and 1 partial ⚠️
front/src/common/BootstrapSNCF/DropdownSNCF.tsx	0.00%	10 Missing and 1 partial ⚠️
...or/tools/routeEdition/components/RouteMetadata.tsx	0.00%	9 Missing and 1 partial ⚠️
front/src/common/Map/WarpedMap/WarpedMap.tsx	0.00%	9 Missing and 1 partial ⚠️
...editor/tools/routeEdition/components/EndPoints.tsx	0.00%	8 Missing and 1 partial ⚠️
...tor/tools/rangeEdition/speedSection/SpeedInput.tsx	0.00%	6 Missing and 1 partial ⚠️
...ront/src/common/Map/Settings/MapSettingsLayers.tsx	0.00%	6 Missing and 1 partial ⚠️
...mon/Map/Settings/MapSettingsBackgroundSwitches.tsx	0.00%	5 Missing and 1 partial ⚠️
...or/components/InfraErrors/InfraErrorMapControl.tsx	0.00%	4 Missing and 1 partial ⚠️
... and 53 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff              @@
##                dev    #8664      +/-   ##
============================================
- Coverage     36.87%   36.83%   -0.05%     
- Complexity     2177     2217      +40     
============================================
  Files          1255     1255              
  Lines        113719   113832     +113     
  Branches       3203     3187      -16     
============================================
- Hits          41938    41931       -7     
- Misses        69886    70009     +123     
+ Partials       1895     1892       -3     

Flag	Coverage Δ
core	74.77% <ø> (-0.03%)	⬇️
editoast	71.72% <ø> (-0.02%)	⬇️
front	14.93% <11.55%> (-0.03%)	⬇️
gateway	2.20% <ø> (ø)
osrdyne	2.71% <ø> (ø)
railjson_generator	87.49% <ø> (ø)
tests	86.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[emersion]

Nice!

[SharglutDev]

Thank you for this PR ! The eslint config doesn't catch type FC in import React (FC is still there in all IncompatibleConstraints components)

[Caracol3]

Lgtm

[emersion]

Thank you for this PR ! The eslint config doesn't catch type FC in import React (FC is still there in all IncompatibleConstraints components)

Indeed! Added a rule for lone FC and dropped all remaining references (there were quite a few... !).

[SharglutDev]

Lgtm, thank you for the follow up @emersion :)