-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable /search
dry
parameter in non-debug builds & harmonize endpoint results
#8673
Conversation
f169293
to
6cf0afb
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8673 +/- ##
============================================
- Coverage 36.88% 36.87% -0.02%
Complexity 2213 2213
============================================
Files 1253 1253
Lines 113838 113832 -6
Branches 3185 3185
============================================
- Hits 41991 41974 -17
- Misses 69955 69966 +11
Partials 1892 1892
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me, but I'm not sure I understand the purpose of PR...
Can you add some context to the PR description?
6cf0afb
to
db1ce27
Compare
/search
dry
parameter in non-debug builds/search
dry
parameter in non-debug builds & harmonize endpoint results
Good point, sorry. Updated. While doing that I recalled we needed to change the response of the endpoint. This PR now also includes that. |
db1ce27
to
84d3107
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The
dry
parameter is useful for debugging the query being generated by the search expression. It's not necessary in production. Moreover we spotted during theaxum
migration that the/search
endpoint sometimes returns json (search results) or text (dry
). This PR harmonizes that.