-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: fix deleted trainrun #8689
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8689 +/- ##
============================================
- Coverage 36.82% 36.81% -0.02%
Complexity 2213 2213
============================================
Files 1254 1254
Lines 113698 113706 +8
Branches 3185 3185
============================================
- Hits 41866 41857 -9
- Misses 69940 69957 +17
Partials 1892 1892
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(I wouldn't mind duplicating the getTrainrunSectionsByTrainrunId()
call in both cases FWIW, or even moving that call into createTrainSchedulePayload()
)
I've also considered doing it. |
becacae
to
7bbb177
Compare
front/src/applications/operationalStudies/components/MacroEditor/ngeToOsrd.ts
Outdated
Show resolved
Hide resolved
front/src/applications/operationalStudies/components/MacroEditor/ngeToOsrd.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tested
2c6110d
to
ea2cd41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working fine, thanks :)
- when deleting trainrun skips getTrainrunSectionsByTrainrunId function - rebase dev
ea2cd41
to
2fe634f
Compare
When deleting trainrun skips getTrainrunSectionsByTrainrunId function, as this function searches for sections according to trainrun id.
When deleting a trainrun, no sections are found which returns an error and cancels the deletion.
close #8688