Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: converting train labels between osrd and nge #8692

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

Uriel-Sautron
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron commented Sep 2, 2024

first part of #8397

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 70 lines in your changes missing coverage. Please review.

Project coverage is 37.03%. Comparing base (ef349bf) to head (c497dae).

Files with missing lines Patch % Lines
...ationalStudies/components/MacroEditor/osrdToNge.ts 0.00% 40 Missing ⚠️
...ationalStudies/components/MacroEditor/ngeToOsrd.ts 0.00% 14 Missing and 1 partial ⚠️
...cations/operationalStudies/components/NGE/types.ts 0.00% 15 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8692      +/-   ##
============================================
- Coverage     37.05%   37.03%   -0.03%     
  Complexity     2209     2209              
============================================
  Files          1255     1255              
  Lines        114138   114192      +54     
  Branches       3182     3182              
============================================
- Hits          42293    42289       -4     
- Misses        69953    70011      +58     
  Partials       1892     1892              
Flag Coverage Δ
core 74.79% <ø> (ø)
editoast 72.44% <ø> (-0.02%) ⬇️
front 14.91% <0.00%> (-0.02%) ⬇️
gateway 2.20% <ø> (ø)
osrdyne 2.71% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Uriel-Sautron Uriel-Sautron marked this pull request as ready for review September 6, 2024 10:25
@Uriel-Sautron Uriel-Sautron requested a review from a team as a code owner September 6, 2024 10:25
Copy link
Contributor

@Caracol3 Caracol3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (tested)

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, left just one comment

@louisgreiner
Copy link
Contributor

Seems like there is something missing for the synchronization when we create a label from OSRD and then try to visualize it in NGE
image

@louisgreiner louisgreiner changed the title front: converting labels between osrd and nge front: converting train labels between osrd and nge Sep 9, 2024
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm (ok for merge after @emersion approval :)

@Uriel-Sautron Uriel-Sautron force-pushed the usn/labels-osrd-nge branch 2 times, most recently from a53b4ab to 052c5f0 Compare September 10, 2024 18:33
@louisgreiner louisgreiner force-pushed the usn/labels-osrd-nge branch 5 times, most recently from c497dae to 4576b95 Compare September 12, 2024 07:19
  - convert labels from nge to orsd

front: convert labels from osrd to nge

front: management of identical labels

front: auto-increment id

front: add LabelGroup for NGE
@louisgreiner louisgreiner added this pull request to the merge queue Sep 12, 2024
Merged via the queue into dev with commit a10e889 Sep 12, 2024
23 checks passed
@louisgreiner louisgreiner deleted the usn/labels-osrd-nge branch September 12, 2024 09:26
@louisgreiner louisgreiner added the module:operational-studies Multi-train simulation with structured studies management label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:operational-studies Multi-train simulation with structured studies management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants