-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: converting train labels between osrd and nge #8692
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8692 +/- ##
============================================
- Coverage 37.05% 37.03% -0.03%
Complexity 2209 2209
============================================
Files 1255 1255
Lines 114138 114192 +54
Branches 3182 3182
============================================
- Hits 42293 42289 -4
- Misses 69953 70011 +58
Partials 1892 1892
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4bda055
to
90793ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (tested)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR, left just one comment
front/src/applications/operationalStudies/components/MacroEditor/osrdToNge.ts
Outdated
Show resolved
Hide resolved
90793ec
to
52015f0
Compare
52015f0
to
d4ff03b
Compare
front/src/applications/operationalStudies/components/MacroEditor/osrdToNge.ts
Outdated
Show resolved
Hide resolved
front/src/applications/operationalStudies/components/MacroEditor/ngeToOsrd.ts
Show resolved
Hide resolved
d4ff03b
to
df29688
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm (ok for merge after @emersion approval :)
df29688
to
3386ab8
Compare
front/src/applications/operationalStudies/components/MacroEditor/osrdToNge.ts
Outdated
Show resolved
Hide resolved
a53b4ab
to
052c5f0
Compare
c497dae
to
4576b95
Compare
- convert labels from nge to orsd front: convert labels from osrd to nge front: management of identical labels front: auto-increment id front: add LabelGroup for NGE
4576b95
to
877061f
Compare
first part of #8397