Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: removes fixtures V1 #8697

Merged
merged 2 commits into from
Sep 3, 2024
Merged

editoast: removes fixtures V1 #8697

merged 2 commits into from
Sep 3, 2024

Conversation

leovalais
Copy link
Contributor

Subsequent PRs:

  • remove DbPoolV1
  • rename DbPoolV2 to DbPool

@leovalais leovalais requested a review from a team as a code owner September 2, 2024 15:06
@leovalais leovalais requested a review from hamz2a September 2, 2024 15:06
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.82%. Comparing base (fa9ff3a) to head (ec80273).
Report is 14 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8697      +/-   ##
============================================
- Coverage     36.85%   36.82%   -0.03%     
  Complexity     2217     2217              
============================================
  Files          1255     1254       -1     
  Lines        113827   113721     -106     
  Branches       3187     3187              
============================================
- Hits          41951    41880      -71     
+ Misses        69984    69949      -35     
  Partials       1892     1892              
Flag Coverage Δ
core 74.77% <ø> (ø)
editoast 71.81% <ø> (+0.01%) ⬆️
front 14.93% <ø> (ø)
gateway 2.20% <ø> (ø)
osrdyne 2.71% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leovalais leovalais enabled auto-merge September 2, 2024 15:12
Copy link
Contributor

@hamz2a hamz2a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks !

Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less lines of code, yeah 🎉

@leovalais leovalais added this pull request to the merge queue Sep 3, 2024
Merged via the queue into dev with commit 97a9bae Sep 3, 2024
22 checks passed
@leovalais leovalais deleted the lva/remove-v1-fixtures branch September 3, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants