Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: update useMemo() dependencies in useOutputTableData() #8722

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

emersion
Copy link
Member

@emersion emersion commented Sep 3, 2024

pathProperties and path aren't consumed by this function, so drop them. pathStepsWithOpPointIndices was consumed but was missing from the dependencies.

pathProperties and path aren't consumed by this function, so drop
them. pathStepsWithOpPointIndices was consumed but was missing from
the dependencies.
@emersion emersion requested a review from a team as a code owner September 3, 2024 14:02
@emersion emersion self-assigned this Sep 3, 2024
Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@emersion emersion added this pull request to the merge queue Sep 4, 2024
Merged via the queue into dev with commit 22213ba Sep 4, 2024
22 checks passed
@emersion emersion deleted the emr/drop-unnecessary-output-table-data-deps branch September 4, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants