-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: stdcm: refactor time data into a new data class #8740
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8740 +/- ##
============================================
- Coverage 37.03% 37.02% -0.02%
- Complexity 2208 2212 +4
============================================
Files 1255 1256 +1
Lines 113915 113997 +82
Branches 3188 3188
============================================
+ Hits 42190 42205 +15
- Misses 69830 69896 +66
- Partials 1895 1896 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cab1681
to
410ede9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :)
5912b17
to
dae0702
Compare
we were computing redundant stuff with the refacto, and the comment was outdated
dae0702
to
6f283c9
Compare
Fix #8587
Now is the time for reviews about these time fields, their name, their structure, their docstrings, and so on
Change summary: