Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: stdcm: refactor time data into a new data class #8740

Merged
merged 4 commits into from
Sep 9, 2024

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Sep 4, 2024

Fix #8587

Now is the time for reviews about these time fields, their name, their structure, their docstrings, and so on

Change summary:

  1. Move time-related data from edges and nodes into a new struct
  2. Improve how these values are forwarded between nodes and edges
  3. Add comments for what still needs to be changed for variable stop times

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 93.06931% with 7 lines in your changes missing coverage. Please review.

Project coverage is 37.02%. Comparing base (91e7663) to head (6f283c9).
Report is 9 commits behind head on dev.

Files with missing lines Patch % Lines
.../main/kotlin/fr/sncf/osrd/stdcm/graph/STDCMEdge.kt 80.00% 1 Missing and 1 partial ⚠️
.../main/kotlin/fr/sncf/osrd/stdcm/graph/STDCMNode.kt 88.23% 1 Missing and 1 partial ⚠️
.../sncf/osrd/stdcm/graph/PostProcessingSimulation.kt 50.00% 1 Missing ⚠️
...in/fr/sncf/osrd/stdcm/graph/STDCMPostProcessing.kt 66.66% 0 Missing and 1 partial ⚠️
...c/main/kotlin/fr/sncf/osrd/stdcm/graph/TimeData.kt 95.45% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8740      +/-   ##
============================================
- Coverage     37.03%   37.02%   -0.02%     
- Complexity     2208     2212       +4     
============================================
  Files          1255     1256       +1     
  Lines        113915   113997      +82     
  Branches       3188     3188              
============================================
+ Hits          42190    42205      +15     
- Misses        69830    69896      +66     
- Partials       1895     1896       +1     
Flag Coverage Δ
core 74.79% <93.06%> (+0.04%) ⬆️
editoast 72.15% <ø> (-0.05%) ⬇️
front 14.95% <ø> (-0.02%) ⬇️
gateway 2.20% <ø> (ø)
osrdyne 2.71% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eckter eckter force-pushed the ech/rework-stdcm-times branch 4 times, most recently from cab1681 to 410ede9 Compare September 6, 2024 09:14
@eckter eckter marked this pull request as ready for review September 6, 2024 09:26
@eckter eckter requested a review from a team as a code owner September 6, 2024 09:26
@eckter eckter requested review from Khoyo and Erashin and removed request for Khoyo September 6, 2024 09:26
Copy link
Contributor

@Erashin Erashin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@eckter eckter force-pushed the ech/rework-stdcm-times branch from 5912b17 to dae0702 Compare September 6, 2024 12:32
@eckter eckter force-pushed the ech/rework-stdcm-times branch from dae0702 to 6f283c9 Compare September 6, 2024 12:32
@eckter eckter enabled auto-merge September 6, 2024 12:32
@eckter eckter added this pull request to the merge queue Sep 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 6, 2024
@eckter eckter added this pull request to the merge queue Sep 9, 2024
Merged via the queue into dev with commit 14e5230 Sep 9, 2024
22 checks passed
@eckter eckter deleted the ech/rework-stdcm-times branch September 9, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core: stdcm: rework timing data along edges and nodes
3 participants