Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: Import trainSchedules from Viriato file #8756

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

RomainValls
Copy link
Contributor

@RomainValls RomainValls commented Sep 4, 2024

closes #8718

To test the feature, download the folder containing the different import files.
We're testing the imports "Etoile de Veynes", "Etude Medoc", "MSC-AIX_LNPCA", "RP Trame" and "Test_Vir4".
Link to the files :
https://sncf.sharepoint.com/sites/OSRD644GrpO365/Documents%20partages/Forms/AllItems.aspx?id=%2Fsites%2FOSRD644GrpO365%2FDocuments%20partages%2FDonn%C3%A9es%2F3%2DFichiers%20Viriato&viewid=21cdca8b%2D1763%2D4a6e%2Da9e3%2Dc9c036f6a510

Many trains are invalid :
In most cases, it's due to the fact that the rolling stock is not found :

  • Edit the train
  • Check the error popup message with the rollingstock name
  • Try changing the rollingstock with the correct one

When we have a rollingstock, sometimes we have errors :

  • Pathfinding works but the simulation fails
  • Pathfinding doesn't work (most of the time -> Canton manquant)

What would be nice, for a future feature, is to be able to multi edit the invalid trains, and affect them correct rollingstocks simultaneously.

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 284 lines in your changes missing coverage. Please review.

Project coverage is 38.44%. Comparing base (214ceb1) to head (fcde8a9).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
.../ImportTrainSchedule/ImportTrainScheduleConfig.tsx 0.00% 137 Missing ⚠️
...ts/ManageTrainSchedule/helpers/handleParseFiles.ts 0.00% 61 Missing and 1 partial ⚠️
front/src/common/uploadFileModal.tsx 0.00% 36 Missing ⚠️
...ortTrainSchedule/generateTrainSchedulesPayloads.ts 0.00% 23 Missing ⚠️
...nts/ManageTrainSchedule/helpers/trainNameHelper.ts 0.00% 14 Missing and 1 partial ⚠️
...ortTrainSchedule/ImportTrainScheduleTrainsList.tsx 0.00% 8 Missing ⚠️
...rc/common/Map/Search/useSearchOperationalPoint.tsx 0.00% 2 Missing ⚠️
.../components/SpaceTimeChart/useLazyProjectTrains.ts 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8756      +/-   ##
============================================
- Coverage     38.55%   38.44%   -0.11%     
  Complexity     2244     2244              
============================================
  Files          1286     1287       +1     
  Lines         97963    98217     +254     
  Branches       3256     3257       +1     
============================================
- Hits          37769    37764       -5     
- Misses        58263    58521     +258     
- Partials       1931     1932       +1     
Flag Coverage Δ
core 74.78% <ø> (ø)
editoast 72.09% <ø> (-0.02%) ⬇️
front 10.15% <0.00%> (-0.06%) ⬇️
gateway 2.22% <ø> (ø)
osrdyne 2.43% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RomainValls RomainValls force-pushed the rvs/front-import-viriato-file-in-timetable branch from 3c7bfbf to 3d481a4 Compare September 5, 2024 07:09
@RomainValls RomainValls added the area:front Work on Standard OSRD Interface modules label Sep 5, 2024
@RomainValls RomainValls force-pushed the rvs/front-import-viriato-file-in-timetable branch 3 times, most recently from dbdd49c to e91052c Compare September 12, 2024 10:03
@RomainValls RomainValls force-pushed the rvs/front-import-viriato-file-in-timetable branch from 56cc1b6 to 37415d9 Compare September 23, 2024 14:12
@RomainValls RomainValls self-assigned this Sep 23, 2024
@RomainValls RomainValls marked this pull request as ready for review September 23, 2024 14:53
@RomainValls RomainValls requested a review from a team as a code owner September 23, 2024 14:53
@RomainValls RomainValls requested a review from emersion October 1, 2024 13:51
@RomainValls RomainValls force-pushed the rvs/front-import-viriato-file-in-timetable branch from 2f1de27 to 712da8f Compare October 1, 2024 14:17
@github-actions github-actions bot removed the area:front Work on Standard OSRD Interface modules label Oct 3, 2024
@RomainValls RomainValls force-pushed the rvs/front-import-viriato-file-in-timetable branch 3 times, most recently from 274c29a to 043ec59 Compare October 8, 2024 13:37
@clarani
Copy link
Contributor

clarani commented Oct 10, 2024

Tested, the test file can be imported ✅

Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm =)

@RomainValls RomainValls force-pushed the rvs/front-import-viriato-file-in-timetable branch from 322f92c to d9ff508 Compare October 10, 2024 09:50
@emersion
Copy link
Member

Can all of the commits be squashed together (or re-split into logical commits)?

@RomainValls RomainValls force-pushed the rvs/front-import-viriato-file-in-timetable branch from d9ff508 to 85f7a99 Compare October 10, 2024 09:57
@RomainValls RomainValls force-pushed the rvs/front-import-viriato-file-in-timetable branch from 85f7a99 to fcde8a9 Compare October 10, 2024 10:00
@RomainValls RomainValls added this pull request to the merge queue Oct 10, 2024
@emersion
Copy link
Member

Thanks for that!

Merged via the queue into dev with commit 78d7cf3 Oct 10, 2024
24 checks passed
@RomainValls RomainValls deleted the rvs/front-import-viriato-file-in-timetable branch October 10, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import trainSchedules from a Viriato file
5 participants