-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: Import trainSchedules from Viriato file #8756
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8756 +/- ##
============================================
- Coverage 38.55% 38.44% -0.11%
Complexity 2244 2244
============================================
Files 1286 1287 +1
Lines 97963 98217 +254
Branches 3256 3257 +1
============================================
- Hits 37769 37764 -5
- Misses 58263 58521 +258
- Partials 1931 1932 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3c7bfbf
to
3d481a4
Compare
dbdd49c
to
e91052c
Compare
56cc1b6
to
37415d9
Compare
front/src/modules/trainschedule/components/ImportTrainSchedule/ImportTrainScheduleConfig.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/trainschedule/components/ImportTrainSchedule/ImportTrainScheduleConfig.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/trainschedule/components/ImportTrainSchedule/ImportTrainScheduleConfig.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/trainschedule/components/ImportTrainSchedule/ImportTrainScheduleConfig.tsx
Outdated
Show resolved
Hide resolved
2f1de27
to
712da8f
Compare
...t/src/modules/trainschedule/components/ImportTrainSchedule/ImportTrainScheduleTrainsList.tsx
Outdated
Show resolved
Hide resolved
...t/src/modules/trainschedule/components/ImportTrainSchedule/ImportTrainScheduleTrainsList.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/trainschedule/components/ImportTrainSchedule/ImportTrainScheduleConfig.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/trainschedule/components/ImportTrainSchedule/ImportTrainScheduleConfig.tsx
Outdated
Show resolved
Hide resolved
274c29a
to
043ec59
Compare
front/src/modules/trainschedule/components/ManageTrainSchedule/helpers/handleParseFiles.ts
Outdated
Show resolved
Hide resolved
front/src/modules/trainschedule/components/ManageTrainSchedule/helpers/trainNameHelper.ts
Outdated
Show resolved
Hide resolved
Tested, the test file can be imported ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm =)
322f92c
to
d9ff508
Compare
Can all of the commits be squashed together (or re-split into logical commits)? |
d9ff508
to
85f7a99
Compare
Signed-off-by: romainvalls <[email protected]>
85f7a99
to
fcde8a9
Compare
Thanks for that! |
closes #8718
To test the feature, download the folder containing the different import files.
We're testing the imports "Etoile de Veynes", "Etude Medoc", "MSC-AIX_LNPCA", "RP Trame" and "Test_Vir4".
Link to the files :
https://sncf.sharepoint.com/sites/OSRD644GrpO365/Documents%20partages/Forms/AllItems.aspx?id=%2Fsites%2FOSRD644GrpO365%2FDocuments%20partages%2FDonn%C3%A9es%2F3%2DFichiers%20Viriato&viewid=21cdca8b%2D1763%2D4a6e%2Da9e3%2Dc9c036f6a510
Many trains are invalid :
In most cases, it's due to the fact that the rolling stock is not found :
When we have a rollingstock, sometimes we have errors :
What would be nice, for a future feature, is to be able to multi edit the invalid trains, and affect them correct rollingstocks simultaneously.