Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use design system font in new STDCM interface #8760

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

kmer2016
Copy link
Contributor

@kmer2016 kmer2016 commented Sep 5, 2024

closes #8727

@kmer2016 kmer2016 requested a review from a team as a code owner September 5, 2024 06:56
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 37.07%. Comparing base (950a5b1) to head (afe78e1).
Report is 7 commits behind head on dev.

Files with missing lines Patch % Lines
...ons/stdcm/components/SimulationReportStyleSheet.ts 0.00% 9 Missing ⚠️
...tions/stdcmV2/components/StdcmEmptyConfigError.tsx 0.00% 2 Missing ⚠️
...cmV2/components/StdcmResults/StdcmResultsTable.tsx 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8760      +/-   ##
============================================
+ Coverage     37.03%   37.07%   +0.03%     
  Complexity     2212     2212              
============================================
  Files          1253     1255       +2     
  Lines        113882   114111     +229     
  Branches       3188     3189       +1     
============================================
+ Hits          42173    42303     +130     
- Misses        69813    69911      +98     
- Partials       1896     1897       +1     
Flag Coverage Δ
core 74.79% <ø> (ø)
editoast 72.41% <ø> (+0.01%) ⬆️
front 14.94% <0.00%> (-0.02%) ⬇️
gateway 2.20% <ø> (ø)
osrdyne 2.71% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmer2016 kmer2016 force-pushed the cnh/fix-stdcm-font branch 2 times, most recently from e550025 to 1c335e8 Compare September 9, 2024 14:18
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With firefox, the font seems to be there but I have this error in console when using the v2 interface when editing the consist

Capture d’écran 2024-09-10 à 09 23 43

and on chrome, I have this :
Capture d’écran 2024-09-10 à 15 07 24

@kmer2016 kmer2016 force-pushed the cnh/fix-stdcm-font branch 3 times, most recently from bfdfb36 to 2f27b55 Compare September 10, 2024 14:56
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, good job !

@kmer2016 kmer2016 added this pull request to the merge queue Sep 10, 2024
Merged via the queue into dev with commit 1cfd54c Sep 10, 2024
23 checks passed
@kmer2016 kmer2016 deleted the cnh/fix-stdcm-font branch September 10, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply design system font in STDCM
3 participants