Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: i18n: rollingstock.json spelling #8763

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

SergeCroise
Copy link
Contributor

  • électrique
  • sélection

@SergeCroise SergeCroise requested a review from a team as a code owner September 5, 2024 07:35
@emersion
Copy link
Member

emersion commented Sep 5, 2024

Sounds like CI isn't happy about the commit title somehow… It sounds like it rejects digits in module names…

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.97%. Comparing base (d261967) to head (c0520a3).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

❗ There is a different number of reports uploaded between BASE (d261967) and HEAD (c0520a3). Click for more details.

HEAD has 13 uploads less than BASE
Flag BASE (d261967) HEAD (c0520a3)
railjson_generator 2 0
gateway 2 0
osrdyne 2 0
tests 2 0
front 2 1
core 2 0
editoast 2 0
Additional details and impacted files
@@              Coverage Diff              @@
##                dev    #8763       +/-   ##
=============================================
- Coverage     37.03%   14.97%   -22.07%     
=============================================
  Files          1255      593      -662     
  Lines        113915    65938    -47977     
  Branches       3188     1103     -2085     
=============================================
- Hits          42192     9871    -32321     
+ Misses        69828    54971    -14857     
+ Partials       1895     1096      -799     
Flag Coverage Δ
core ?
editoast ?
front 14.97% <ø> (ø)
gateway ?
osrdyne ?
railjson_generator ?
tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emersion
Copy link
Member

emersion commented Sep 5, 2024

Sounds like CI isn't happy about the commit title somehow… It sounds like it rejects digits in module names…

Fix for that in #8764

Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@SergeCroise
Copy link
Contributor Author

Sounds like CI isn't happy about the commit title somehow… It sounds like it rejects digits in module names…

Fix for that in #8764
Hello @emersion , I would like to understand how to merge this PR too:
OpenRailAssociation/osrd-ui#392

@SergeCroise SergeCroise requested a review from emersion September 5, 2024 08:21
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing :)

For the check_commit, I think the test doesn't like your : after i18n

@emersion
Copy link
Member

emersion commented Sep 5, 2024

@SergeCroise Regarding PRs that we forget about: feel free to add a comment in the PR asking for attention, and I'd recommend joining our Matrix channel to communicate with us.

@emersion
Copy link
Member

emersion commented Sep 5, 2024

Can you rebase on top of #8764?

@SergeCroise SergeCroise requested review from a team as code owners September 6, 2024 09:20
@SergeCroise SergeCroise requested a review from eckter September 6, 2024 09:20
@SergeCroise SergeCroise marked this pull request as draft September 6, 2024 09:23
- electrique
- selection
@SergeCroise SergeCroise marked this pull request as ready for review September 6, 2024 09:45
@SergeCroise
Copy link
Contributor Author

hi @emersion , please review !

Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@emersion emersion removed request for a team and eckter September 6, 2024 09:50
@emersion emersion enabled auto-merge September 6, 2024 09:50
@emersion emersion added this pull request to the merge queue Sep 6, 2024
Merged via the queue into OpenRailAssociation:dev with commit a419de4 Sep 6, 2024
22 checks passed
@SergeCroise SergeCroise deleted the patch-2 branch September 6, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants