-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: i18n: rollingstock.json spelling #8763
Conversation
SergeCroise
commented
Sep 5, 2024
- électrique
- sélection
Sounds like CI isn't happy about the commit title somehow… It sounds like it rejects digits in module names… |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files@@ Coverage Diff @@
## dev #8763 +/- ##
=============================================
- Coverage 37.03% 14.97% -22.07%
=============================================
Files 1255 593 -662
Lines 113915 65938 -47977
Branches 3188 1103 -2085
=============================================
- Hits 42192 9871 -32321
+ Misses 69828 54971 -14857
+ Partials 1895 1096 -799
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Fix for that in #8764 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing :)
For the check_commit, I think the test doesn't like your :
after i18n
@SergeCroise Regarding PRs that we forget about: feel free to add a comment in the PR asking for attention, and I'd recommend joining our Matrix channel to communicate with us. |
Can you rebase on top of #8764? |
- electrique - selection
hi @emersion , please review ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!