Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: pathfinding: log a little extra info about failures #8769

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Sep 5, 2024

We barely logged anything on pathfindings. We now log:

  1. success
  2. no path found at all, including the last reached waypoint index
  3. no path found because of [constraint type / error type]

Not much, but it can still help

This PR also fixes the "couldn't find route" error, it had an irrelevant type.

@eckter eckter requested a review from a team as a code owner September 5, 2024 12:26
@eckter eckter requested review from Khoyo and bougue-pe and removed request for Khoyo September 5, 2024 12:26
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 36.90%. Comparing base (c2b8718) to head (335c785).
Report is 13 commits behind head on dev.

Files with missing lines Patch % Lines
.../kotlin/fr/sncf/osrd/sim_infra/utils/InfraUtils.kt 0.00% 1 Missing ⚠️
.../api_v2/pathfinding/PathfindingBlocksEndpointV2.kt 83.33% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8769      +/-   ##
============================================
- Coverage     36.91%   36.90%   -0.01%     
  Complexity     2208     2208              
============================================
  Files          1255     1255              
  Lines        114115   114126      +11     
  Branches       3188     3188              
============================================
+ Hits          42120    42122       +2     
- Misses        70100    70109       +9     
  Partials       1895     1895              
Flag Coverage Δ
core 74.75% <86.66%> (+0.02%) ⬆️
editoast 72.04% <ø> (-0.04%) ⬇️
front 14.92% <ø> (ø)
gateway 2.20% <ø> (ø)
osrdyne 2.71% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bougue-pe bougue-pe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (feel free to resolve comment)

@eckter eckter added this pull request to the merge queue Sep 6, 2024
Merged via the queue into dev with commit fe8e4b7 Sep 6, 2024
22 checks passed
@eckter eckter deleted the ech/log-pathfinding branch September 6, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants